Improvements for the file tree view in the panel popup
ClosedPublic

Authored by abika on Aug 7 2016, 5:26 PM.

Details

Summary

Varioux fixes and improvents, most important:

  • added a right-click context menu for column header with option "show details": if disabled only the file names are shown
  • showing folder in tree view is fixed and synchronized with folder in (this) panel view

I would like to make the "brief mode" (=only file names) the default: This is imo what most users would expect and more usable.
If you agree i'll add it.

Commits:

Moved KrFileTreeView from PanelPopup to own files

Fixing micro-second rename on double-click in file tree view

Added brief mode for file tree view

Fix selecting and showing folder when tree view is opened

Save/restore tree view brief mode setting

Minor coding improvements

Synchronize tree view directory with panel directory

Removed unused methods in tree view class

Ah, and a screenshot:

Test Plan
  • switching between "brief" and "details" mode + save/restore
  • navigating /folder change

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abika updated this revision to Diff 5721.Aug 7 2016, 5:26 PM
abika retitled this revision from to Improvements for the file tree view in the panel popup.
abika updated this object.
abika edited the test plan for this revision. (Show Details)
abika added a reviewer: Krusader.
abika updated this object.Aug 7 2016, 5:30 PM
martinkostolny accepted this revision.Aug 7 2016, 8:59 PM
martinkostolny added a reviewer: martinkostolny.
martinkostolny added a subscriber: martinkostolny.

Great work, thanks!

I agree with the default brief mode in tree view.

This revision is now accepted and ready to land.Aug 7 2016, 8:59 PM
asensi accepted this revision.Aug 9 2016, 9:48 PM
asensi added a reviewer: asensi.
asensi added a subscriber: asensi.

Various fixes and improvents, most important:

  • added a right-click context menu for column header with option "show details": if disabled only the file names are shown
  • showing folder in tree view is fixed and synchronized with folder in (this) panel view

Thanks, Alex!

I agree with the default brief mode in tree view.

I agree, too! :-)

gengisdave accepted this revision.Aug 13 2016, 8:09 PM
gengisdave added a reviewer: gengisdave.
abika updated this revision to Diff 5907.Aug 14 2016, 12:22 PM
abika edited edge metadata.
  • Set brief mode for file tree view by default
Closed by commit R167:e275439d7093: Improvements for the file tree view in the panel popup (authored by Alexander Bikadorov <bikaejkb@mailbox.tu-berlin.de>). · Explain WhyAug 14 2016, 12:25 PM
This revision was automatically updated to reflect the committed changes.