With these changes: more than four characters (in this moment, a constant equal to five) are used to represent a compressed file type, so the bzip2 type can be represented as "bzip2" instead of "zip2", etc. Some compressed file types had a dash as a first character, some others didn't; with these changes: no type has a dash as a first character.
Details
Details
- Reviewers
martinkostolny gengisdave - Group Reviewers
Krusader - Maniphest Tasks
- T2768: Normalize some compressed file types and deduplicate code in krarc.cpp and krarchandler.cpp.
I performed several operations (opening, extracting) with the new source code, using 28 different compressed files. Those operations left a trace (in /tmp/krdebug), that trace was the same (excluding some trivial changes like the numbers of the lines of the source code) than the trace obtained using the previous source code and the same operations.
Diff Detail
Diff Detail
- Repository
- R167 Krusader
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
It it can be useful to anyone, in order to help to compare traces obtained from /tmp/krdebug:
This is a command that supresses the first column (the one that has a PID) of a trace, and supresses whatever exists between parenthesis (because several line numbers are usually changed between development sessions):
cat krdebug | cut -d ' ' -f 2- | sed 's/(.*)//g' > file_that_can_be_more_easily_compared