First steps to normalize some compressed file types and to deduplicate code in krarc.cpp and krarchandler.cpp.
ClosedPublic

Authored by asensi on May 29 2016, 7:23 PM.

Details

Summary

With these changes: more than four characters (in this moment, a constant equal to five) are used to represent a compressed file type, so the bzip2 type can be represented as "bzip2" instead of "zip2", etc. Some compressed file types had a dash as a first character, some others didn't; with these changes: no type has a dash as a first character.

Test Plan

I performed several operations (opening, extracting) with the new source code, using 28 different compressed files. Those operations left a trace (in /tmp/krdebug), that trace was the same (excluding some trivial changes like the numbers of the lines of the source code) than the trace obtained using the previous source code and the same operations.

Diff Detail

Repository
R167 Krusader
Lint
Lint Skipped
Unit
Unit Tests Skipped
asensi updated this revision to Diff 4041.May 29 2016, 7:23 PM
asensi retitled this revision from to First steps to normalize some compressed file types and to deduplicate code in krarc.cpp and krarchandler.cpp..
asensi updated this object.
asensi edited the test plan for this revision. (Show Details)
asensi added a reviewer: Krusader.
asensi set the repository for this revision to R167 Krusader.
asensi added a project: Krusader.
asensi added a subscriber: Krusader.

It it can be useful to anyone, in order to help to compare traces obtained from /tmp/krdebug:

This is a command that supresses the first column (the one that has a PID) of a trace, and supresses whatever exists between parenthesis (because several line numbers are usually changed between development sessions):

cat krdebug | cut -d ' ' -f 2-  | sed 's/(.*)//g' > file_that_can_be_more_easily_compared
asensi updated this revision to Diff 4072.May 30 2016, 1:40 PM
asensi updated this object.
asensi edited the test plan for this revision. (Show Details)

Minor simplifications, solutions and clarifications were made.

martinkostolny accepted this revision.Jun 5 2016, 10:27 PM
martinkostolny added a reviewer: martinkostolny.
martinkostolny added a subscriber: martinkostolny.

Perfect, thanks! (Sorry for the waiting)

This revision is now accepted and ready to land.Jun 5 2016, 10:27 PM
gengisdave accepted this revision.Jun 19 2016, 4:46 PM
gengisdave added a reviewer: gengisdave.
asensi closed this revision.Jun 19 2016, 5:55 PM