The checkbox is used for setting the variable containOnRemote in VFS/krQuery. This is a switch to omit content search for non-local files. Most likely to prevent heavy unwanted network IO.

I agree that this doesn't make much sense: You either want to search network locations or you don't. But for later you wouldn't have added a remote search location.

Imo feel free to remove it but please with all the code remains that were connected to it.

I agree.

If it may be useful: just for trying, I mounted a remote filesystem using ~/temporary, and when searching inside ~/temporary: disabling the "Remote content search" checkbox had no effect.

I mounted a remote filesystem using ~/temporary, and when searching inside ~/temporary: disabling the "Remote content search" checkbox had no effect.

Well, yes, thats why its so useless: The check for the remote location is done with

vf->vfile_getUrl().isLocalFile()

And the docs for "isLocalFile()" says

Returns true if this URL is pointing to a local file path. A URL is a local file path if the scheme is "file".

So, all files on a mounted network filesystem are "local" to this definition. A nice example for a good idea that turns out to be quite useless if the implementation went wrong.

A real solution is more complicated and could be done with QStorageInfo. I'm not sure if its worth the effort.

I agree, the analysis is right; it is also needed to search into archives (because they have the tar: krarc: or zip: scheme).

The QStorageInfo seems to be the final solution, but I don't know if it worths.

Looking in krusader/VFS/krquery.cpp:324, the flag always true seems to have no impact on local files.

I will search in old commits, it seems to be an old hack to avoid freezes on low bandwitdh connection.

EDIT : commit found, no relevant info https://quickgit.kde.org/?p=krusader.git&a=commit&h=0beda3af9f2590340a3681802c5c7c1258743f13

Thanks a lot for guidance and information from all of you. I'll remove the checkbox along with all the connected code. The found commit will be helpful, thanks Davide! I'll provide a diff soon.