Ctrl+F in lister puts selected text to search textfield
ClosedPublic

Authored by martinkostolny on Apr 15 2016, 4:10 PM.

Details

Reviewers
asensi
gengisdave
Group Reviewers
Krusader
Maniphest Tasks
T1970: Various Lister Issues
Summary

When Ctrl+F is hit, search textfield is activated but its contents are unchanged and not selected so one has to write down the text to search. This patch is fixing this behaviour to match regular editor behaviour:

  • selected text is put into the search textfield
  • content of search textfield is selected
  • if there is no selected text in editor, search textfield is activated and its existing content is selected
Test Plan
  • select text in lister and press Ctrl+F and press F3 several times (search field should be filled with selected text)
  • select different text and press Ctrl+F and press F3 several times (search field should be filled with selected text)
  • unselect any text in lister and press Ctrl+F (search field content should stay untouched, it should only get selected)

Diff Detail

Repository
R167 Krusader
Lint
Lint Skipped
Unit
Unit Tests Skipped
martinkostolny retitled this revision from to Ctrl+F in lister puts selected text to search textfield.
martinkostolny updated this object.
martinkostolny edited the test plan for this revision. (Show Details)
martinkostolny added a reviewer: Krusader.
martinkostolny set the repository for this revision to R167 Krusader.
martinkostolny added a project: Krusader.
asensi accepted this revision.Apr 20 2016, 9:29 PM
asensi added a reviewer: asensi.
asensi added a subscriber: asensi.

It worked there :-)

This revision is now accepted and ready to land.Apr 20 2016, 9:29 PM
gengisdave accepted this revision.Apr 24 2016, 2:33 PM
gengisdave added a reviewer: gengisdave.

Thanks! Committed.