Lister: fixing esc key always closes lister
ClosedPublic

Authored by martinkostolny on Aug 13 2016, 1:51 PM.

Details

Summary

Currently lister is always closed by escape key no matter what (e.g. while search is in progress). This diff prevents that - search in lister is closed by Esc key. When search is closed, Esc key will close Lister.

Test Plan

Pressing escape while Lister is active when:

  • search is opened (visible) and various items on lister are focused (search buttons, search textfield, editor) -> only closes search
  • search is closed -> exits lister

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
martinkostolny retitled this revision from to Lister: fixing esc key always closes lister.
martinkostolny updated this object.
martinkostolny edited the test plan for this revision. (Show Details)
martinkostolny added a reviewer: Krusader.
martinkostolny set the repository for this revision to R167 Krusader.
gengisdave accepted this revision.Aug 14 2016, 10:01 AM
gengisdave added a reviewer: gengisdave.
gengisdave added a subscriber: gengisdave.

This aligns the Lister to the other file modes.

This revision is now accepted and ready to land.Aug 14 2016, 10:01 AM
asensi accepted this revision.Aug 14 2016, 11:11 AM
asensi added a reviewer: asensi.
asensi added a subscriber: asensi.

Using Kubuntu 16.04: Esc now does not close Lister if the search bar was enabled :-). If the search bar was not enabled, Esc closes Lister, etc. :-) Thanks, Martin!

This revision was automatically updated to reflect the committed changes.

FYI I changed the diff a little bit before committing. Escape key still closed lister when search was actually in progress (when search progressBar was visible). Now this situation is also handled - escape stops searching, closes search area. Another Escape closes lister.