New config options for url navigator bar
Details
Details
- Reviewers
asensi martinkostolny - Group Reviewers
Krusader - Maniphest Tasks
- T3000: Config options for URL navigator
- Commits
- R167:ee6a07f2c686: Updated config options for new URL navigator bar
Diff Detail
Diff Detail
- Repository
- R167 Krusader
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
New options are working. Thanks a lot, Alex!
PS: I've just discovered that if I uncheck Flat Origin Bar, Krusader crashes and can never be started again. So it is definitely good that this option was now removed. :)
Comment Actions
- Fixing behaviour of url navigator (1) after focus loss and (2) after url was changed
Comment Actions
It is definitely better now, thanks!
Though I would still suggest to add a support for Esc key to cancel any changes (and return to browse mode if Edit Mode by Default is unchecked).
Also I've encountered a crash:
- Lock a tab
- Edit path in URL navigator and press enter
Interestingly when clicking apply button, it works fine. Can you also replicate this behaviour?
Not so related, but interesting one more thing I've encountered when testing: If I insert url with hash, e.g. "/home/user/#hashfolder/hello", it fails to enter the folder. But it seems to be a bug in KUrlNavigator itself because Dolphin has this problem, too, it only acts a bit differently -> enters the nearest folder ("/home/user"). I'll try to investigate this one more and propose a patch to KIO or at least file a bug.
Comment Actions
In the end I ended up fixing the hash problem on Krusader side (D2022) but I appreciate any other opinions on this matter. Thanks!
Comment Actions
- Fixing behaviour of url navigator (1) after focus loss and (2) after url was changed
- Fixed failed assert if focus is requested after new tab creation
Comment Actions
ok, first the crash: It was not related to the URL navigator, it also happened with the URL requester. But fixed now anyway.
Comment Actions
about the escape key: This one was tricky. There is a default shortcut set with the escape key for getting the panel focus . Cause there was no way to the navigator getting the key event I reset the shortcut to "control+escape". (It was the same for the old url requester but again nobody noticed it). It should work now, tested with "navigator mode" and "edit mode".
And thanks for testing!
Comment Actions
Hm-m-m... Ctrl-Esc is the default global KDE shortcut for "System Activity" (analog of Ctrl-Alt-Del in Windows). How is it supposed to work in KDE?
Thanks in advance for your answer.
Comment Actions
Hm-m-m... Ctrl-Esc is the default global KDE shortcut for "System Activity" (analog of Ctrl-Alt-Del in Windows). How is it supposed to work in KDE?
Oho. Ok, this solution was certainly crap. I just found out about ShortcutOverride events and will work on a better solution asap.