I think that this implementation is much more cleaner

What is the problem with that @laysrodrigues ?

This is a problem that need to be solved in atcore, and not doing workarounds in the printerhost.

In D10645#209208, @rizzitello wrote:

In D10645#209201, @patrickelectric wrote:

@rizzitello I'll ping the #Solid people about this.

it not so much solid does not work on windows , its more we were not deploying it .. and qt provides us with a system independent way to do this with objects we are already using

Good patch, but before merging it, I would ask for two days after this message to talk with the Solid people about this issue.

@rizzitello I'll ping the #Solid people about this.

isn't this a solid bug ?

A last thing, this patch have some trailing spaces !

Great job ! LGTM !

In D10436#204545, @rizzitello wrote:

In D10436#204418, @patrickelectric wrote:

Why we are doing tests with descriptions ?

For exactly the same reason we were checking the toString calls to have full test coverage.

Why we are doing tests with descriptions ?

In D10423#204087, @rizzitello wrote:

Future tooltips for any other rectify buttons may need to be tweaked when
we have them.

merged.

The best thing is to replace the gcode class to more generic classes. But
remove this abstraction is a kickback, we can use this class to provide a
lot of important information to the graphic interface, gcode editor, gcode
information and etc.. besides that, isn't hard to maintain what is standard
protocol, only small things change between this main class.
If the gcode class isn't helpfully we need to reformulate it and no remove.

In D10331#203357, @rizzitello wrote:

In D10331#203355, @patrickelectric wrote:

In D10331#202789, @rizzitello wrote:

• Remove Use of gcodecommands
• Remove GcodeCommands

why ??

• Less code to maintain
• Lots of code for little gain
• Code is slightly more readabe in atcore with only QStringLiteral("G28") instead of GCode::toCommand(GCode::G28));
• GCode::toString was used 5 times. Strings returned by this might not be accurate for your firmware. This class contained lots of strings for the translators that we never used. Maybe this could be used in atelier to help users make gcodes ? ?

In D10331#202789, @rizzitello wrote:

• Remove Use of gcodecommands
• Remove GcodeCommands

we can merge this ?

Use this and not ref

@rizzitello I think that this need more love from our part.

• Firmware: Add default validateCommand
• Firmware: Add default translate
• binary compatibility ftw !

Sith comments

• Firmware: Add default translate

• atcore: Only print if connected

• Do not send serial commands if serial isn't open
• atcore: Only print if connected

Update.

• Do not change to printing states if disconnected
• Do not send serial commands if serial isn't open

Merge asap