how many users are there?

attic/modules/FindTaglib.cmake shall be deleted.

Maybe also update the commit message to 'Create specific directory for Qt logging categories file'

In D21313#469311, @mlaurent wrote:

Ping ?

Looks mostly fine safe for the directory name that needs the major version to avoid conflicts when libfoo.categories built using KF5 will have to coexist with KF6.
It needs a '5' in its name.

In D21214#465253, @vkrause wrote:

This was added to fix static builds (for which we also need private link dependencies here too). I guess putting that into an if (NOT @BUILD_SHARED_LIBS@) conditional might be the right solution?

Reenable the QT_DISABLE_DEPRECATED_BEFORE line, the mentioned issue was fixed
in Qt 5.13 beta2.

tested successfully with & without program and when using the 'default' button.

In D20489#449133, @dfaure wrote:

cgiboudeaux: the Qt documentation says that foreach is deprecated, what do you suggest Laurent should add to the commit log? Just "it's deprecated", a copy/paste of the Qt docu, or https://www.kdab.com/goodbye-q_foreach/ ?

In D20489#448703, @mlaurent wrote:

what is the problem with title ?

Please fix the title

Kopete needs a build fix:

correct

In D20005#437052, @aacid wrote:

Well, KF5I18nConfig.cmake includes KF5I18nMacros.cmake that requires Qt5Widgets.

Does it? it doesn't here, or you mean "requires Qt5Widgets" because it tries to use Qt5::uic ?

In D20005#437029, @cgiboudeaux wrote:

In D20005#436993, @aacid wrote:

That not ideal, ki18n should be usable for projects that don't use widgets too.

I'd say the bug is on the calling cmake side, if it has a ui file it must surely depend on widgets on the calling side, so just add it there?

Well, KF5I18nConfig.cmake includes KF5I18nMacros.cmake that requires Qt5Widgets.

For a better visibility, I think adding this to KF5I18nConfig.cmake.in is better:

include(CMakeFindDependencyMacro)
find_dependency(Qt5Widgets @REQUIRED_QT_VERSION@)

In D20005#436993, @aacid wrote:

That not ideal, ki18n should be usable for projects that don't use widgets too.

I'd say the bug is on the calling cmake side, if it has a ui file it must surely depend on widgets on the calling side, so just add it there?

FTR, the fix was pushed, but now the BSD build is unhappy.