Differential D21205

Fix a potential build issue when building KMail
ClosedPublic
Actions

Authored by krop on May 14 2019, 7:44 AM.

Details

Reviewers
mlaurent
vandenoever
Commits
R92:cea29406f7a1: Fix a potential build issue when building KMail
Summary

some public mailcommon headers include libkdepim ones but the build system
currently doesn't look for this dependency.

Let's look for libkdepim for building mailcommon and explicitly add
KF5::Libkdepim to the 'PUBLIC' link targets to fix the
INTERFACE_LINK_LIBRARIES instead of relying on indirect dependencies.

Also fix a wrong #include statement.

BUG: 407163
FIXED-IN: 5.11.2

Diff Detail

Repository
R92 PIM: Common Mail Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
krop created this revision.May 14 2019, 7:44 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 14 2019, 7:44 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
krop requested review of this revision.May 14 2019, 7:44 AM
mlaurent accepted this revision.May 14 2019, 11:08 AM
This revision is now accepted and ready to land.May 14 2019, 11:08 AM
Closed by commit R92:cea29406f7a1: Fix a potential build issue when building KMail (authored by krop). · Explain WhyMay 14 2019, 11:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (1 line)
MKF5MailCommonConfig.cmake.in (1 line)
Msrc/CMakeLists.txt (1 line)
Msrc/job/backupjob.h (3 lines)

Diff 58059

View Options

CMakeLists.txt

Loading...
View Options

KF5MailCommonConfig.cmake.in

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/job/backupjob.h

Loading...