KF5Codecs is not a public link target.
Details
Details
- Reviewers
- None
Diff Detail
Diff Detail
- Repository
- R180 PIM: KMime
- Branch
- Applications/19.04
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11830 Build 11848: arc lint + arc unit
Comment Actions
This was added to fix static builds (for which we also need private link dependencies here too). I guess putting that into an if (NOT @BUILD_SHARED_LIBS@) conditional might be the right solution?
Comment Actions
interesting, as I see similar commits in other repos, do you remember which kmime dependencies were failing to build?
Comment Actions
Anything depending on KMime would fail to build (if KMime is built statically), unless it itself was searching for all private link dependencies of KMime anyway. I did those fixes when doing a (partial) static build of KDE Itinerary for Android, but probably in a too aggressive way also affecting shared builds.