Fix the kmime dependencies.
Needs ReviewPublic

Authored by krop on May 14 2019, 1:42 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

KF5Codecs is not a public link target.

Diff Detail

Repository
R180 PIM: KMime
Branch
Applications/19.04
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11830
Build 11848: arc lint + arc unit
krop created this revision.May 14 2019, 1:42 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 14 2019, 1:42 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
krop requested review of this revision.May 14 2019, 1:42 PM

This was added to fix static builds (for which we also need private link dependencies here too). I guess putting that into an if (NOT @BUILD_SHARED_LIBS@) conditional might be the right solution?

krop added a comment.May 14 2019, 3:31 PM

This was added to fix static builds (for which we also need private link dependencies here too). I guess putting that into an if (NOT @BUILD_SHARED_LIBS@) conditional might be the right solution?

interesting, as I see similar commits in other repos, do you remember which kmime dependencies were failing to build?

Anything depending on KMime would fail to build (if KMime is built statically), unless it itself was searching for all private link dependencies of KMime anyway. I did those fixes when doing a (partial) static build of KDE Itinerary for Android, but probably in a too aggressive way also affecting shared builds.