Differential D20270

Remove the sortable addressee list, and all its supporting infrastructure
ClosedPublic
Actions

Authored by vkrause on Apr 5 2019, 2:46 PM.

Details

Reviewers
dvratil
Commits
R174:3a552d912435: Remove the sortable addressee list, and all its supporting infrastructure
Summary

This is unused, and some of its template code wasn't even inline, making
it even technically impossible to be used externally.

Diff Detail

Repository
R174 KContacts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Apr 5 2019, 2:46 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 5 2019, 2:46 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Apr 5 2019, 2:46 PM
dvratil accepted this revision.Apr 5 2019, 3:40 PM
This revision is now accepted and ready to land.Apr 5 2019, 3:40 PM
Closed by commit R174:3a552d912435: Remove the sortable addressee list, and all its supporting infrastructure (authored by vkrause). · Explain WhyApr 6 2019, 3:18 PM
This revision was automatically updated to reflect the committed changes.
krop added a subscriber: krop.Apr 6 2019, 9:56 PM

Kopete needs a build fix:

[ 393s] /home/abuild/rpmbuild/BUILD/kopete-19.03.60git.20190310T032402~4110bd231/libkopete/ui/addressbookselectorwidget.h:43:7: error: using typedef-name 'KContacts::AddresseeList' after 'class'
[ 393s] class AddresseeList;
[ 393s] ^~~~~~~~~~~~~
[ 393s] In file included from /usr/include/KF5/KContacts/kcontacts/addressee.h:45,
[ 393s] from /home/abuild/rpmbuild/BUILD/kopete-19.03.60git.20190310T032402~4110bd231/libkopete/ui/addressbooklinkwidget.h:27,
[ 393s] from /home/abuild/rpmbuild/BUILD/kopete-19.03.60git.20190310T032402~4110bd231/libkopete/ui/addressbooklinkwidget.cpp:24:
[ 393s] /usr/include/KF5/KContacts/kcontacts/addresseelist.h:33:28: note: 'KContacts::AddresseeList' has a previous declaration here
[ 393s] typedef QVector<Addressee> AddresseeList;
[ 393s] ^~~~~~~~~~~~~
[ 393s] In file included from /home/abuild/rpmbuild/BUILD/kopete-19.03.60git.20190310T032402~4110bd231/libkopete/ui/addressbookselectordialog.h:22,
[ 393s] from /home/abuild/rpmbuild/BUILD/kopete-19.03.60git.20190310T032402~4110bd231/libkopete/ui/addressbookselectordialog.cpp:19:
[ 393s] /home/abuild/rpmbuild/BUILD/kopete-19.03.60git.20190310T032402~4110bd231/libkopete/ui/addressbookselectorwidget.h:43:7: error: using typedef-name 'KContacts::AddresseeList' after 'class'
[ 393s] class AddresseeList;
[ 393s] ^~~~~~~~~~~~~
[ 393s] In file included from /usr/include/KF5/KContacts/kcontacts/addressee.h:45,
[ 393s] from /home/abuild/rpmbuild/BUILD/kopete-19.03.60git.20190310T032402~4110bd231/libkopete/ui/addressbookselectorwidget.h:31,
[ 393s] from /home/abuild/rpmbuild/BUILD/kopete-19.03.60git.20190310T032402~4110bd231/libkopete/ui/addressbookselectordialog.h:22,
[ 393s] from /home/abuild/rpmbuild/BUILD/kopete-19.03.60git.20190310T032402~4110bd231/libkopete/ui/addressbookselectordialog.cpp:19:
[ 393s] /usr/include/KF5/KContacts/kcontacts/addresseelist.h:33:28: note: 'KContacts::AddresseeList' has a previous declaration here
[ 393s] typedef QVector<Addressee> AddresseeList;
[ 393s] ^~~~~~~~~~~~~

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (1 line)
Msrc/addresseelist.h (387 lines)
DMsrc/addresseelist.cpp (361 lines)

Diff 55568

View Options

src/CMakeLists.txt

Loading...
View Options

src/addresseelist.h

Loading...
View Options

src/addresseelist.cpp

Loading...