| apol |
| Frameworks |
If I have
find_package(KF5I18n ${KF5_MIN_VERSION} CONFIG REQUIRED)in CMakeLists.txt, cmake failed with the following error:
get_target_property() called with non-existent target "Qt5::uic".
referencing the following line in KF5I18nMacros.cmake:
get_target_property(QT_UIC_EXECUTABLE Qt5::uic LOCATION)
Run cmake on a project with the following lines:
find_package(KF5I18n ${KF5_MIN_VERSION} CONFIG REQUIRED)
ki18n_wrap_ui(foo_SRCS bar.ui)| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I'm not sure about this because
That not ideal, ki18n should be usable for projects that don't use widgets too.
I'd say the bug is on the calling cmake side, if it has a ui file it must surely depend on widgets on the calling side, so just add it there?
Well, KF5I18nConfig.cmake includes KF5I18nMacros.cmake that requires Qt5Widgets.
For a better visibility, I think adding this to KF5I18nConfig.cmake.in is better:
include(CMakeFindDependencyMacro) find_dependency(Qt5Widgets @REQUIRED_QT_VERSION@)
and in a different commit add
find_dependency(Qt5Core @REQUIRED_QT_VERSION@)
which is a public link target of ki18n
But does the code *really* need qwidget? I
Does it? it doesn't here, or you mean "requires Qt5Widgets" because it tries to use Qt5::uic ?
Yes, but Qt5::uic is only used if you call KI18N_WRAP_UI, if you call KI18N_WRAP_UI is because you have .ui files in your project, if you have .ui files in your project, your project should be depending on Qt5Widgets, if it's not, it's a bug because you are directly using Qt5Widgets, so just add it there.
Making ki18n depend on Qt5Widgets unconditionally because a function that you may call if you use Qt5Widgets needs Qt5Widgets doesn't seem the best of the ideas to me, there's valid use cases for ki18n to not use Qt5Widgets and in those cases it'll never go thorough KI18N_WRAP_UI, so it will just work.