I have the feeling that it should be a KAbstractFileItemActionPlugin? It's how we implemented it for KDE Connect at least and it should be more generic.

Good idea!
How about looking for the rpm and dpkg executables?

Looks better, thanks!

Looks like it's missing checking the exit argument in ::cleanup() for ExitFailed no? Can you check if in this case we're getting the an ExitFailed? If so the setStatus should go there.

Thanks!

In T8425#137515, @aacid wrote:

Looking at @jriddell script and without being a ruby reader i see it seems to create the announcement page, the changelog page and the info page.

address kai's remarks

In D13102#268015, @cgiboudeaux wrote:

Please update the doc above.

Don't we have to make sure path is relative to the package root?

Okay, let's land this and I'll try to fix it myself.

In D12896#267091, @nicolasfella wrote:

In D12896#266713, @apol wrote:

Then just read the Exec field and we'll add the sendpath by hand. This is ad-hoc for telegram anyway.

I'm not quite sure what to do. Best I came up with is something like

execStr = parseExec()

if (execStr.contains("flatpak"))
    execStr += "-sendpath @@ url @@"
else
    execStr += "-sendpath url"

Is this what you had in mind?

Include a test for item views

ping

In D12896#266351, @nicolasfella wrote:

I've played around with flatpaked Telegram and made it working. However:
My Telegram.desktop file executes this:
/usr/bin/flatpak run --branch=stable --arch=x86_64 --command=telegram-desktop --file-forwarding org.telegram.desktop -- @@u %u @@
I can share a file using
/usr/bin/flatpak run --branch=stable --arch=x86_64 --command=telegram-desktop --file-forwarding org.telegram.desktop -sendpath @@ /home/nico/test.py @@
But that would require changing the command I get from the desktop file. I can achieve the same goal just by appending something to the command from the desktop file:
/usr/bin/flatpak run --branch=stable --arch=x86_64 --command=telegram-desktop --file-forwarding org.telegram.desktop -- @@u %u @@ -sendpath @@ /home/nico/test.py @@
However, appending this to the command does not work with the regular command.
I don't see any way to support all without some special-case handling for flatpak. I didn't even test snap.
Any ideas?

Hey,
Interesting work. Some thoughts:

• having a vertical alignment between the icon and the stars breaks the fact that we only had 1 thing at the left on the vertical views. This adds clutter.
• we won't be able to vertically align the stars and the icon on the left, it may look crowded
• it would be interesting to see whether this matches the Cards concept Marco had in mind.
• for now I'd have all items in the same view have the same size and layout, otherwise it will scroll weirdly.
• the progress bar on the last screenshot doesn't look like Breeze scroll bars. Please don't make high definition mockups with the wrong components because everyone gets sad afterwards.
• breeze stars are blue.

What's the status of this?

In D12896#265606, @nicolasfella wrote:

Can this even work with Telegram installed as sandboxed Flatpak?

I guess this can be closed now, correct?

Had a discussion with F-Droid today. Now the plan is to create our own F-Droid repository with the Android binaries coming from binary-factory.kde.org.

Remove hardcoded path

LGTM

Don't add logic in core/ just in case

Could be this bug: https://bugs.kde.org/show_bug.cgi?id=394043
Or this one if you are using flatpak: https://bugs.kde.org/show_bug.cgi?id=385754