make sure paths in rcc are never derived from absolute paths
ClosedPublic

Authored by mart on May 24 2018, 11:05 AM.

Details

Summary

the paths for rcc plasmoids are always in the form
:/plasma/plasmoids/pluginname/
when setPath is called with a full path, strip out everything
but the last org.kde.*

Test Plan

doubleclick/dnd on widget explorer works again

Diff Detail

Repository
R290 KPackage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.May 24 2018, 11:05 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 24 2018, 11:05 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.May 24 2018, 11:05 AM
apol added a subscriber: apol.May 24 2018, 11:26 AM

Don't we have to make sure path is relative to the package root?

src/kpackage/package.cpp
554

Use midRef

mart updated this revision to Diff 34807.May 24 2018, 11:35 AM
  • e midRef
mart added a comment.May 24 2018, 11:37 AM
In D13092#267702, @apol wrote:

Don't we have to make sure path is relative to the package root?

at this point we already know that absolute path is correct (regarding the actual filesystem), under defaultpackageroot and all.
we are just building a fake path to where store the resource files in

mart marked an inline comment as done.May 24 2018, 11:37 AM
apol accepted this revision.May 24 2018, 4:28 PM
This revision is now accepted and ready to land.May 24 2018, 4:28 PM
This revision was automatically updated to reflect the committed changes.