fix i18n issues in framworks/purpose/plugins
ClosedPublic

Authored by lueck on May 25 2018, 6:03 PM.

Details

Summary

add missing TRANSLATION_DOMAIN to CMakeLists.txt to load the catalogs

email

no *.rc + *.u files
rm $EXTRACTRC

kdeconnect i18n() only in qml

use i18nd()

nextcloud i18n() in qml + in cpp

no *.rc + *.u files
rm $EXTRACTRC

reviewboard i18n() in qml + in cpp

ok

saveas i18n() in qml + in cpp

no *.rc + *.u files
rm $EXTRACTRC

imgur i18n() in cpp

no *.rc + *.u files
rm $EXTRACTRC

twitter 2 i18n() in qml

no *.rc + *.u files
rm $EXTRACTRC
only qml -> use i18nd()

ktp-sendfile 1 i18n() in cpp

no *.rc + *.u files
rm $EXTRACTRC

phabricator i18n() in qml + in cpp

no *.rc + *.u files
rm $EXTRACTRC

youtube i18n() in qml + in cpp

no *.rc + *.u files
rm $EXTRACTRC

pastebin i18n() in cpp

no *.rc + *.u files
rm $EXTRACTRC

telegram/Messages.sh, but no i18n()

rm Messages.sh
Test Plan

path/to/l10n-kf5/scripts/extract-messages.sh creates all catalogs

Diff Detail

Repository
R495 Purpose Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lueck created this revision.May 25 2018, 6:03 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 25 2018, 6:03 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
lueck requested review of this revision.May 25 2018, 6:03 PM
apol accepted this revision.May 25 2018, 6:32 PM
apol added a subscriber: apol.

Thanks!

This revision is now accepted and ready to land.May 25 2018, 6:32 PM
aacid added a subscriber: aacid.May 25 2018, 9:16 PM

Are you sure you need the backslashes in add_definitions?

lueck added a comment.May 26 2018, 7:00 AM

Are you sure you need the backslashes in add_definitions?

probably not.
i simply used what is used in the majority of all modules (frameworks, workspace, kde*, pim), except okular an a few others
and okular is translated, so it should work without backslashes.
want me to remove the backslashes?

aacid added a comment.May 26 2018, 9:11 AM

if there's other places using the backslash it's fine, no need to change :)

This revision was automatically updated to reflect the committed changes.