Why?

This change caused the build of libkdegames to start failing as it was missing the majority of it's dependencies, as visible at:
https://build.kde.org/view/CI%20Management/job/Dependency%20Build%20Applications%20kf5-qt5%20FreeBSDQt5.10/6/consoleText

As this could have wider impacts on other projects I thought it best to revert in order to minimize system breakage while the impact of this (in case other projects are also affected) is assessed.

Looking at the change, it is otherwise correct though.

In R857:0d78f5b23dfc07f8e4b9251c8ba9c150aae5b6a8#3661717, @bcooksley wrote:

This change caused the build of libkdegames to start failing as it was missing the majority of it's dependencies, as visible at:
https://build.kde.org/view/CI%20Management/job/Dependency%20Build%20Applications%20kf5-qt5%20FreeBSDQt5.10/6/consoleText

As this could have wider impacts on other projects I thought it best to revert in order to minimize system breakage while the impact of this (in case other projects are also affected) is assessed.

Looking at the change, it is otherwise correct though.

From dependency-data-kf5-qt5:

kde/kdegames/libkdegames: -frameworks/kf5umbrella
kde/kdegames/libkdegames: frameworks/kcoreaddons
kde/kdegames/libkdegames: frameworks/kconfig
kde/kdegames/libkdegames: frameworks/kwidgetsaddons
kde/kdegames/libkdegames: frameworks/kcodecs
kde/kdegames/libkdegames: frameworks/karchive

With my patch I get:

$ python3 ~/devel/playground/ci-tooling/helpers/list-dependencies.py --platform SUSEQt5.10 libkdegames
extra-cmake-modules
kcoreaddons
kconfig
kwidgetsaddons
kcodecs
karchive

Which is correct.

There's a bunch of needed libraries missing though as suggested by the error in build.kde.org.
I suggest fix dependency-data-kf5-qt5 and reapply the patch.

That seems reasonable. A quick grep also shows that these projects will also be affected:

kde/kdeedu/analitza: -frameworks/kf5umbrella
kde/kdeedu/kalgebra: -frameworks/kf5umbrella
kde/kdeedu/minuet: -frameworks/kf5umbrella
extragear/office/alkimia: -frameworks/kf5umbrella
extragear/pim/trojita: -frameworks/kf5umbrella

For Alkimia and Trojita I believe those are Qt only so they shouldn't have any problems.

Only other project in this list which other things depend on is Analitza - can you confirm it's dependencies are correct as well before reapplying this?
(The impact of having leaf projects - those with nothing depending on them - breaking is much lower so we can fix those when they show up)

Yes, for kalgebra and analitza it's perfectly fine. I'll fix libkdegames and reapply the patch.