I saw this happen with kdecoration from git since
64d9f92f6a8708814f414dda0bb0d0e91c27235f. The directory passed in
its ki18n_install call doesn't exist, resulting in an empty
directory (LOCALE_INSTALL_DIR) getting installed, which at least
some packaging systems don't like.
Details
Details
Tested with kdecoration from git and tarballs where podir
exists
Diff Detail
Diff Detail
- Repository
- R249 KI18n
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks fine by me, let's see if there are other comments.
| cmake/KF5I18NMacros.cmake.in | ||
|---|---|---|
| 138–141 | I guess that those two lines are the critical parts (the call to file), but probably it's not bad to avoid processing other instructions too. | |
Comment Actions
Considering the feedback I'll probably merge this in a few days if no objections turn up in the meantime.
| cmake/KF5I18NMacros.cmake.in | ||
|---|---|---|
| 138–141 | Yes. And that was my thought as well and reason to move the rest inside the if | |