Pid changes look fine, though perhaps we should just throw those two lines away? With Qt5 logging the pid is fairly pointless because one can simply set QT_MESSAGE_PATTERN to include the pid when necessary https://doc.qt.io/qt-5/qtglobal.html#qSetMessagePattern

I have zero background knowledge here, but it really feels like there must be an existing solution to this problem other than libmagic. Like how does kate figure out the encoding of a text file.

Sure, I was referring to the smb module, not even kio-extras as a whole. ^^

Shouldn't we just make the entire thing QT_NO_CAST_TO_ASCII by default?

Looks reasonable.

@bcooksley I would think the CI image needs to ship some general purpose schemas. install https://software.opensuse.org/package/gsettings-desktop-schemas I guess.

Coding style is actually wildly inconsistent in that file, so I've stuck to what similar other lines have.

And didn't we have a better spinny box for byte units somewhere? Where the user can put 1 byte or 1 kib or 1 gib and the box knows what to do?

I'm very open for better labels, it's a horrible concept to explain in a few words.

improve label a tad

I am kind of thinking the cast should be asserted or if'd. But I suppose that doesn't add much over just letting it crash on the null dereference.

Only the ones inside the if ( !testdir.isEmpty() ) { branch though, right? The others I'm not sure are for parsing.

Hm. So, this is a bit complicated I've noticed.

Looks reasonable. Though... Shouldn't that rather be any protocol that isn't file? Or at least all that are remote? (assuming we have a way of telling which slaves are remote)

My point is that this diff adds kguiaddons as a link library but doesn't actually use any symbol, so it may as well not be a link library (or something ought to call some function of kguiaddons so it actually links it) ;)

FYI linking a library without actually using any symbols is not going to do anything in practice because many distros link with --as-needed which undoes unnecessary linking. also see https://markmail.org/message/m3mdrsfgxoyfjtte

chop instead of convoluted remove

reshuffle: instead of using .local directly use a fake .kio-disocvery-wsd suffix. look for that at listing time and redirect to name.local or name as appropriate

use other string