fix line rating for new format when function name is missing
ClosedPublic

Authored by sitter on Mar 13 2020, 2:32 PM.

Details

Summary

previously this supposedly was

#2 0x00007fefe9ef79e8 in ?? () at /usr/lib/dri/i965_dri.so

nowadays the ?? is simply empty. the rating mechanism wasn't properly
handling this. treat an empty function name to mean the same as ?? and
rate the line as MissingFunction/Everything depending on whether
libraryName is also missing.

also update test expectations accordingly (could have actually seen that
discrepancy if one had paid attention to the outcoming rating :S)

CCBUG: 418538

Test Plan

test passes. most lines from 417435 now rate MissingFunction and the whole trace is considered useless

Rating: 128 out of 364 Usefulness: Useless
90%: 327.6 70%: 254.8 40%: 145.6

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Mar 13 2020, 2:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 13 2020, 2:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Mar 13 2020, 2:32 PM
ngraham accepted this revision.Mar 16 2020, 5:30 PM
This revision is now accepted and ready to land.Mar 16 2020, 5:30 PM

This doesn't apply cleanly.

Ah, yes, that's where those "packagekit" lines are. Thanks :)

This revision was automatically updated to reflect the committed changes.