Differential D27982

use better strings for dri devices
ClosedPublic
Actions

Authored by sitter on Mar 11 2020, 1:18 PM.

Details

Reviewers
ngraham
Commits
R102:b7d462e03ce9: use better strings for dri devices
Summary

the /proc based fallback was using the raw entry name (number) to
avoid a new string in 5.18.

the Accelerator grouping entry avoided plural mutation for 5.18.

Test Plan

hoping for the best!

Diff Detail

Repository
R102 KInfoCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Mar 11 2020, 1:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 11 2020, 1:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Mar 11 2020, 1:18 PM
ngraham added a subscriber: ngraham.Mar 11 2020, 2:35 PM
ngraham added inline comments.
Modules/opengl/opengl.cpp
245–246

What does "Card" mean in this context? A graphics card?

sitter added inline comments.Mar 11 2020, 3:44 PM
Modules/opengl/opengl.cpp
245–246

Relates to D27980

a card here is a "3D Accelerator" "Card". whatever that means...
It's a graphics card essentially, except, technically not a graphics card, also technically not a card, that's just how we enumerate it on a system level. This is the mirror term for what we call it in the get_drm_devices_sysfs() variant, there it's the verbatim device name card0,card1,card2... while here we don't have that (or at least I don't think we have) hence the bespoke 'Card 0', 'Card 1', 'Card 2' string.

ngraham accepted this revision.Mar 11 2020, 4:14 PM
This revision is now accepted and ready to land.Mar 11 2020, 4:14 PM
Closed by commit R102:b7d462e03ce9: use better strings for dri devices (authored by sitter). · Explain WhyApr 3 2020, 1:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MModules/opengl/opengl.cpp (2 lines)

Diff 79218

View Options

Modules/opengl/opengl.cpp

Loading...