Drop klauncher usage from KCrash
ClosedPublic
Actions

Authored by davidedmundson on Mar 27 2020, 12:04 PM.

Details

Reviewers

Commits

R285:d8e41e64b7d0: Drop klauncher usage from KCrash

Summary

As per other discussions, kdeinit has limited gains and is not widely
deployed in KDE application. KInit as a framework is on its way out.

As such using klauncher to restart a crashed application has no benefit,
we can drop it and simplify the code significantly.

It also means restarted apps stay within any namespaces set up by the launcher.

Test Plan

killall -SEGV on plasmashell and dolphin
Both restarted as expected
The direct code path already existed, so should be safe to use

Repository

R285 KCrash

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

sitter added a subscriber: sitter.

sitter added inline comments.

src/kcrash.cpp
626	This seems to serve no purpose anymore. startProcessInternal could be merged into this so there's only one startProcess function left.

This revision is now accepted and ready to land.Apr 8 2020, 10:30 AM

and merge methods

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/kcrash.h (2 lines)
M			src/kcrash.cpp (177 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	78636	91129f2		Mar 27 2020, 12:04 PM	★	★
Diff 2	79634	4297a0a	and merge methods	Apr 8 2020, 10:49 AM	★	★
Diff 3	79635	29c23f2	R285:d8e41e64b7d0bcfc757bdb9eb0734262420f41c5	Apr 8 2020, 10:50 AM	★	★