D27804 broke compilation for me because I have the above flag set ;-)
It showed rather some rather nasty QString -> QByteArray conversions in this code.
Details
Details
Now it builds.
Diff Detail
Diff Detail
- Repository
- R320 KIO Extras
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25819 Build 25837: arc lint + arc unit
Comment Actions
It might need some work like here, so one repo at a time I would say.
Even if that would be a goal.
We could target it for KF6.
Comment Actions
Sure, I was referring to the smb module, not even kio-extras as a whole. ^^
Anyway, diff looks reasonable.
| CMakeLists.txt | ||
|---|---|---|
| 60 | Isn't that what I did here? Now all of kio-extras gets that flag. And BTW everything built by kdesrc-build actually builds with this flag (since I have it in my kdesrc-buildrc). But that doesn't allow setting it in ECM, there is more code using ECM out there... | |
| CMakeLists.txt | ||
|---|---|---|
| 60 | Huh, I must have scrolled right past it. All is perfect! | |