Feed Advanced Search

Aug 25 2018

laysrodrigues accepted D15038: Clean up the camera properties.
Aug 25 2018, 12:27 PM
laysrodrigues accepted D15037: Cleanup the QML module usage.
Aug 25 2018, 12:26 PM
laysrodrigues accepted D15036: Add missing copyright headers.
Aug 25 2018, 12:26 PM
laysrodrigues accepted D15035: The default ForwardRenderer is enough there.
Aug 25 2018, 12:25 PM
laysrodrigues accepted D15034: Simplify the code, no need for all those intermediate variables.
Aug 25 2018, 12:24 PM
laysrodrigues accepted D15033: Use a more declarative way to deal with the current file.
Aug 25 2018, 12:22 PM
laysrodrigues accepted D15032: Remove useless objectName.
Aug 25 2018, 12:21 PM
laysrodrigues accepted D15031: Let go of the useless enabled calls.
Aug 25 2018, 12:19 PM
laysrodrigues accepted D15030: Rename AnimatedEntity to SceneEntity.
Aug 25 2018, 12:18 PM
laysrodrigues accepted D15029: Remove the QML files from the target definition.
Aug 25 2018, 12:16 PM
laysrodrigues accepted D15028: Cleanup the unused fps code.
Aug 25 2018, 12:15 PM

Aug 23 2018

laysrodrigues requested changes to D14981: Check for plugins using newer atcore method.
Aug 23 2018, 6:08 PM · Atelier: General Development
laysrodrigues added a comment to T9485: Handle error cases.
  1. I started a job from Atelier
  2. For some reason the connection was lost during that(Maybe bad contact with the cable or whatever)
  3. The printer stopped and Atelier didn't update with any new info.
Aug 23 2018, 5:40 PM · Atelier: AtCore
laysrodrigues added a comment to T9485: Handle error cases.

I missed connection during print time, and the log isn't my main widget during that. So a feedback for the user about an error is needed.

Aug 23 2018, 5:33 PM · Atelier: AtCore
laysrodrigues triaged T9485: Handle error cases as Normal priority.
Aug 23 2018, 5:22 PM · Atelier: AtCore
laysrodrigues created T9485: Handle error cases.
Aug 23 2018, 5:22 PM · Atelier: AtCore

Aug 16 2018

laysrodrigues added inline comments to D12456: Enable a notification system.
Aug 16 2018, 9:51 PM
laysrodrigues updated the diff for D12456: Enable a notification system.
  • Sith suggestions
Aug 16 2018, 9:48 PM
laysrodrigues added a comment to D12456: Enable a notification system.

See if this one for connection is good enough

Aug 16 2018, 9:47 PM
laysrodrigues added a comment to D14837: Reset dial on disconnect.

I can do this call after we close the connection, so the change on the target wont get to the printer. What I would like is not a behavior that seems buggy.

Aug 16 2018, 9:15 PM
laysrodrigues updated the diff for D12456: Enable a notification system.
  • Fixes slot warning
  • Install file notifyrc
Aug 16 2018, 11:18 AM

Aug 15 2018

laysrodrigues added a comment to D12456: Enable a notification system.

It was just a silly mistake... (on your second comment)

Aug 15 2018, 10:29 AM
laysrodrigues updated the diff for D12456: Enable a notification system.

Add info the notifyrc file, because
I though that the lack of info there
wouldnt be a problem.
-> The configuration will only work with the installed
file. We dont have any way to use it as a qrc, as I said
before. Waiting to the guy from KNotification get back to me.

Aug 15 2018, 10:24 AM
laysrodrigues added a comment to D14837: Reset dial on disconnect.

Well, I have seen this on this printer, and I have shown you an evidence, so you are going to block this patch just because you've not seen in other printers?

Aug 15 2018, 10:21 AM
laysrodrigues updated subscribers of D14842: Check if file exists - ChooseFileDialog.

After a discussion here at Akademy, @ngraham convinced me to not open more than one file, at least until we have a queue of print jobs.
Also, on our currently ui if we have more than one file opened, we dont have any way to show to the user which file that we open its the one being printed.
So this patch was just to try to avoid non valid files to show to the user before the print. Because if we check that before printing, when the user gets back to the dialog, he may forget the name of the file, and try the same bad file again.

Aug 15 2018, 10:20 AM
laysrodrigues added a comment to D14837: Reset dial on disconnect.

Tomaz printer resets on connection
But we have a garbage memory value, that shows up when I reconnect the printer.
So I do think that delay to reset our controls is a bad behavior.

Aug 15 2018, 10:17 AM
laysrodrigues committed R231:127d23deb326: Add timer to control the emit change target temp (authored by laysrodrigues).
Add timer to control the emit change target temp
Aug 15 2018, 10:02 AM
laysrodrigues committed R231:93231999e922: Add timer to control the emit change target temp (authored by laysrodrigues).
Add timer to control the emit change target temp
Aug 15 2018, 10:02 AM
laysrodrigues closed D14831: Add timer to control the emit change target temp.
Aug 15 2018, 10:02 AM
laysrodrigues added a comment to D14837: Reset dial on disconnect.

That is a problem because the dial is updated with that memory garbage command, and I think that depending on the printer that can cause issues.
I just rather be safe than sorry.

Aug 15 2018, 9:47 AM
laysrodrigues updated the diff for D12456: Enable a notification system.

Update notifyrc file

Aug 15 2018, 9:37 AM
laysrodrigues added a comment to D14837: Reset dial on disconnect.

Tomaz printer does reset on reconnect. But the value is stored on memory and our widgets aren't destroyed, so when we reconnect, the stored value is used, until we get the first return of the printer.

Aug 15 2018, 7:57 AM
laysrodrigues added a comment to D14842: Check if file exists - ChooseFileDialog.

-> Open a File
-> Move file to an another location
->Click to print

-> If only the moved file is open, nothing happens

-> If is there more than one file open, it shows the moved file at dialog

Aug 15 2018, 7:48 AM

Aug 14 2018

laysrodrigues updated the diff for D12456: Enable a notification system.
  • Some of sith suggestions

Need to think about the error state.
Talked with a maintaner of knotification,
he said that the path install for windows
work, just not have sure about osx. He will
also try to implement the way to embedded the
file using qrc.

Aug 14 2018, 3:57 PM
laysrodrigues requested review of D14842: Check if file exists - ChooseFileDialog.
Aug 14 2018, 3:41 PM
laysrodrigues updated the summary of D14831: Add timer to control the emit change target temp.
Aug 14 2018, 2:40 PM
laysrodrigues updated the diff for D14831: Add timer to control the emit change target temp.

Get focus out back

Aug 14 2018, 2:40 PM
laysrodrigues requested review of D14837: Reset dial on disconnect.
Aug 14 2018, 2:26 PM
laysrodrigues requested review of D14831: Add timer to control the emit change target temp.
Aug 14 2018, 1:24 PM
laysrodrigues committed R232:669c6440f7b3: Improve regex for temperatures (authored by laysrodrigues).
Improve regex for temperatures
Aug 14 2018, 1:22 PM
laysrodrigues committed R232:26e43a1ed45c: Add new test for marlin creality flavor (authored by laysrodrigues).
Add new test for marlin creality flavor
Aug 14 2018, 1:22 PM
laysrodrigues committed R232:3b0ee4fcfa76: Improve regex for temperatures (authored by laysrodrigues).
Improve regex for temperatures
Aug 14 2018, 1:22 PM
laysrodrigues closed D14827: Improve regex for temperatures.
Aug 14 2018, 1:22 PM
laysrodrigues updated the diff for D14827: Improve regex for temperatures.
  • Sith suggestions
Aug 14 2018, 1:02 PM
laysrodrigues added inline comments to D14827: Improve regex for temperatures.
Aug 14 2018, 11:30 AM
laysrodrigues added a comment to D14827: Improve regex for temperatures.

I guess just appending this to the previous revision was to much ? (D14792)
The decodeTemp function is fine as i wrote and tested it last night.

Please use a real return from the printer for your test
Please squash this into one commit that contains both the change and the new test.

Aug 14 2018, 11:29 AM
laysrodrigues added a comment to D14827: Improve regex for temperatures.

Bed Target: https://regex101.com/r/zNvUBm/1
Bed: https://regex101.com/r/TNhQWu/1
Hot end Target: https://regex101.com/r/UbdoSY/1
Hot end: https://regex101.com/r/4uonrX/4

Aug 14 2018, 11:08 AM
laysrodrigues requested review of D14827: Improve regex for temperatures.
Aug 14 2018, 11:07 AM
laysrodrigues added a reviewer for D14792: Improve regex to get bed target tmp: laysrodrigues.
Aug 14 2018, 8:24 AM

Aug 13 2018

laysrodrigues added a comment to D14792: Improve regex to get bed target tmp.

Before: https://regex101.com/r/4uonrX/1/
Now: https://regex101.com/r/bTnVXP/2/

Aug 13 2018, 2:59 PM

Jul 25 2018

laysrodrigues accepted D13978: Atelier Aware if a file is modified on close/ print.
Jul 25 2018, 7:07 PM · Atelier: General Development

Jul 16 2018

laysrodrigues added a comment to D13978: Atelier Aware if a file is modified on close/ print.

can you add screeshots of your use case tests?
Not able to test this at this time.

Jul 16 2018, 3:55 PM · Atelier: General Development
laysrodrigues added a comment to D13969: Change editor default view options.

I would like to have the line-numbers... the others modifications are fine.
Now based on @tcanabrava thoughts, this kind of profiling can be done on KTextEditor options on Atelier Settings->Configure Editor. Those can be just our 'default setup'.

Jul 16 2018, 3:52 PM · Atelier: General Development

Jul 2 2018

laysrodrigues accepted D13859: Hide private implementation classes in order to prevent symbol collision.
Jul 2 2018, 8:34 PM
laysrodrigues accepted D13799: Update Deployment files.
Jul 2 2018, 11:37 AM · Atelier

Jun 28 2018

laysrodrigues accepted D13778: core: Correct emit signal call.
Jun 28 2018, 12:12 PM
laysrodrigues accepted D13779: core: Use mult args QString in arg.
Jun 28 2018, 12:11 PM

Jun 25 2018

laysrodrigues committed R231:fcf7981ce73f: CMakeLists - CleanUp and order elements by alphabetic letters (authored by laysrodrigues).
CMakeLists - CleanUp and order elements by alphabetic letters
Jun 25 2018, 1:31 AM
laysrodrigues committed R231:bfed19947b8f: CMakeLists - CleanUp and order elements by alphabetic letters (authored by laysrodrigues).
CMakeLists - CleanUp and order elements by alphabetic letters
Jun 25 2018, 1:31 AM
laysrodrigues closed D13702: CMakeLists - CleanUp and order elements by alphabetic letters.
Jun 25 2018, 1:31 AM
laysrodrigues updated the diff for D13702: CMakeLists - CleanUp and order elements by alphabetic letters.

Rebase

Jun 25 2018, 1:30 AM

Jun 24 2018

laysrodrigues requested review of D13702: CMakeLists - CleanUp and order elements by alphabetic letters.
Jun 24 2018, 12:13 AM

Jun 23 2018

laysrodrigues committed R870:6db51a41864e: Add rssfeed json file (authored by laysrodrigues).
Add rssfeed json file
Jun 23 2018, 10:19 PM

Jun 21 2018

laysrodrigues accepted D13655: Use 4 Clause connect for lambdas.
Jun 21 2018, 1:34 PM · Atelier: General Development
laysrodrigues committed R231:2cb2b3285665: Small fixes for welcomewidget (authored by laysrodrigues).
Small fixes for welcomewidget
Jun 21 2018, 1:34 PM
laysrodrigues committed R231:8e8267562d0a: Small fixes for welcomewidget (authored by laysrodrigues).
Small fixes for welcomewidget
Jun 21 2018, 1:34 PM
laysrodrigues committed R231:6830a6ed66fd: AStyle fixes (authored by laysrodrigues).
AStyle fixes
Jun 21 2018, 1:34 PM
laysrodrigues closed D13644: Small fixes for welcomewidget.
Jun 21 2018, 1:33 PM
laysrodrigues updated the diff for D13644: Small fixes for welcomewidget.
  • AStyle fixes
Jun 21 2018, 1:31 PM
laysrodrigues accepted D13653: Use 4 clause connect for lambdas.
Jun 21 2018, 1:28 PM · Atelier: AtCore
laysrodrigues accepted D13632: Check more paths for plugins..
Jun 21 2018, 1:27 PM · Atelier: AtCore
laysrodrigues updated the diff for D13644: Small fixes for welcomewidget.

Rebase

Jun 21 2018, 1:27 PM
laysrodrigues updated the diff for D13644: Small fixes for welcomewidget.

Const ref layout

Jun 21 2018, 3:21 AM
laysrodrigues accepted D13561: Scale icons in laterial area based on dpi.
Jun 21 2018, 3:20 AM · Atelier: General Development
laysrodrigues added a comment to D13258: Add Welcome Screen.

Fixes made into:
https://phabricator.kde.org/D13644

Jun 21 2018, 3:13 AM
laysrodrigues requested review of D13644: Small fixes for welcomewidget.
Jun 21 2018, 3:12 AM
laysrodrigues committed R231:2888c3343764: Add Welcome Screen (authored by laysrodrigues).
Add Welcome Screen
Jun 21 2018, 3:12 AM
laysrodrigues committed R231:16b5e08a071b: Use multiple origins for rss feed (authored by laysrodrigues).
Use multiple origins for rss feed
Jun 21 2018, 3:12 AM
laysrodrigues committed R231:17ae3764cfb8: Make 3DView focused when opening a file (authored by laysrodrigues).
Make 3DView focused when opening a file
Jun 21 2018, 3:12 AM
laysrodrigues committed R231:a026755d02d0: Add welcome screen to mainwindow (authored by laysrodrigues).
Add welcome screen to mainwindow
Jun 21 2018, 3:12 AM
laysrodrigues committed R231:6570ef6df9d1: Add WelcomeWidget (authored by laysrodrigues).
Add WelcomeWidget
Jun 21 2018, 3:12 AM
laysrodrigues committed R231:0853dd7e9fb8: Add Atelier svg logo (authored by laysrodrigues).
Add Atelier svg logo
Jun 21 2018, 3:12 AM
laysrodrigues closed D13258: Add Welcome Screen.
Jun 21 2018, 3:12 AM
laysrodrigues updated the diff for D13258: Add Welcome Screen.

Remove empty lines

Jun 21 2018, 1:31 AM

Jun 20 2018

laysrodrigues updated subscribers of D13632: Check more paths for plugins..
Jun 20 2018, 5:30 PM · Atelier: AtCore
laysrodrigues requested changes to D13632: Check more paths for plugins..

also de folder isn't plugins with lower letter case?

Jun 20 2018, 4:37 PM · Atelier: AtCore
laysrodrigues planned changes to D13258: Add Welcome Screen.
Jun 20 2018, 2:05 PM
laysrodrigues updated the diff for D13258: Add Welcome Screen.

Use font size-linespacing for icons

Jun 20 2018, 1:51 PM
laysrodrigues planned changes to D13258: Add Welcome Screen.
Jun 20 2018, 1:50 PM
laysrodrigues accepted D13553: Plugins should report if they support sd cards.
Jun 20 2018, 1:45 PM · Atelier: AtCore
laysrodrigues updated the diff for D13258: Add Welcome Screen.

use QToolButton instead of QPushButton

Jun 20 2018, 1:38 PM
laysrodrigues planned changes to D13258: Add Welcome Screen.
Jun 20 2018, 1:37 PM
laysrodrigues updated the diff for D13258: Add Welcome Screen.

Fixes for fallback

Jun 20 2018, 2:54 AM
laysrodrigues planned changes to D13258: Add Welcome Screen.
Jun 20 2018, 2:54 AM
laysrodrigues triaged T9044: Atelier Plasmoid as Wishlist priority.
Jun 20 2018, 1:53 AM · Atelier

Jun 19 2018

laysrodrigues added a comment to D13258: Add Welcome Screen.

I get a lot of "unable to set layout on QWidget "" because it has a layout" already if the fallback area comes up .. please check how you are setting up the newsWidget to remove these warnings.

Jun 19 2018, 12:50 PM
laysrodrigues added a comment to D13604: Build Flatpak for Atelier.

I think that for this we should wait to move Atelier from Playground to Extragear.

Jun 19 2018, 12:49 PM · Atelier, Flatpak
laysrodrigues updated the diff for D13258: Add Welcome Screen.
  • Add WelcomeWidget
  • Add welcome screen to mainwindow
  • Make 3DView focused when opening a file
  • Use multiple origins for rss feed
Jun 19 2018, 2:02 AM
laysrodrigues planned changes to D13258: Add Welcome Screen.
Jun 19 2018, 1:58 AM
laysrodrigues added inline comments to D13553: Plugins should report if they support sd cards.
Jun 19 2018, 12:54 AM · Atelier: AtCore