Differential D15029

Remove the QML files from the target definition
ClosedPublic
Actions

Authored by ervin on Aug 23 2018, 9:45 PM.

Details

Reviewers
laysrodrigues
tcanabrava
patrickelectric
leandrosantiago
rizzitello
Commits
R231:ae0e7552f743: Remove the QML files from the target definition
Summary

It doesn't quite make sense from the CMake build time perspective
anyway. Only the resource matters there.

Diff Detail

Repository
R231 Atelier
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin requested review of this revision.Aug 23 2018, 9:45 PM
ervin created this revision.
ervin set the repository for this revision to R231 Atelier.Aug 23 2018, 9:53 PM
rizzitello requested changes to this revision.EditedAug 24 2018, 1:53 AM

This Is good but is not based on master. please correct the base, Or after landing D15028 it will then be on the correct base.

This revision now requires changes to proceed.Aug 24 2018, 1:53 AM
tcanabrava accepted this revision.Aug 24 2018, 9:25 AM
laysrodrigues accepted this revision.Aug 25 2018, 12:16 PM
rizzitello accepted this revision.Aug 25 2018, 3:44 PM
This revision is now accepted and ready to land.Aug 25 2018, 3:44 PM
Closed by commit R231:ae0e7552f743: Remove the QML files from the target definition (authored by ervin). · Explain WhyAug 29 2018, 6:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/3dview/CMakeLists.txt (7 lines)

Diff 40600

View Options

src/widgets/3dview/CMakeLists.txt

Loading...