| rizzitello | |
| patrickelectric | |
| tcanabrava |
If you disconnect the printer, when you reconnect,
the needle will point from the target temperature
that was set before disconnect. So to guarantee
that we dont heat without a command from the user,
on every connection we set the temps to 0
Signed-off-by: Lays Rodrigues <lays.rodrigues@kde.org>
| No Linters Available |
| No Unit Test Coverage |
| Buildable 1833 | |
| Build 1851: arc lint + arc unit |
Can you provide an example of this happening.. I have tested several times with master and do not see the set target being retained. This will only happen if your machine doesn't reset on disconnect and in that case your still heating to the set temperature. What about in cases when D13576 is merged?
Tomaz printer does reset on reconnect. But the value is stored on memory and our widgets aren't destroyed, so when we reconnect, the stored value is used, until we get the first return of the printer.
Part 1 on the video is with the patch, part second it is on master branch.
I do not see a problem here. Its ok to have the few seconds of inaccurate dials just like when you connect for the first time and see 0 for a few seconds. If its not sending the command to the printer I see no problem with the current state of master. I just see this causing problems when you add stuff like D13576 later on
That is a problem because the dial is updated with that memory garbage command, and I think that depending on the printer that can cause issues.
I just rather be safe than sorry.
99% of printers reset on connection. This will be broken in Atelier when i land D13576 into atcore. There will be no issues caused by leaving it.
Tomaz printer resets on connection
But we have a garbage memory value, that shows up when I reconnect the printer.
So I do think that delay to reset our controls is a bad behavior.
Well, I have seen this on this printer, and I have shown you an evidence, so you are going to block this patch just because you've not seen in other printers?
That is atelier will be be broken when i merge D13576. My main issue is that aftert D13576 on reconnnect you maybe setting my temps to 0 in the middle of a print job. So lets think here what is worse a 2 second graphical inconsistency on connect or possibly ruining some ones 20 hours print mid print when they connect back to the machine (post D13576)
I can do this call after we close the connection, so the change on the target wont get to the printer. What I would like is not a behavior that seems buggy.