Plugins should report if they support sd cards

Authored by rizzitello on Jun 15 2018, 3:04 AM.



Marlin / Repetier, If the printer says we are printing from sd , we are printing from sd

Add isSdSupported() to plugins returns true if plugin supports Sd Cards

check for sdsupport for opperations
AtCore: Ignore the sd print option of AtCore::print if the loaded plugin lacks sd support

Test Client : Toggle sd widget's visibility based on firmwares support for sd cards.

Signed-off-by: Chris Rizzitello <>

Diff Detail

R232 AtCore
No Linters Available
No Unit Test Coverage
Build Status
Buildable 59
Build 59: arc lint + arc unit
rizzitello requested review of this revision.Jun 15 2018, 3:04 AM
rizzitello created this revision.
rizzitello edited the summary of this revision. (Show Details)Jun 15 2018, 3:11 AM
rizzitello added a reviewer: Atelier: AtCore.
rizzitello added a project: Atelier: AtCore.
rizzitello added a subscriber: Atelier: AtCore.
rizzitello updated this revision to Diff 36228.Jun 16 2018, 2:56 PM
rizzitello edited the summary of this revision. (Show Details)
  • rebase
laysrodrigues added inline comments.

Why are setting the state to BUSY, if on the print method of AtCore you set the state to BUSY if is a print from the sd card?

rizzitello added inline comments.Jun 19 2018, 1:03 AM

This is incase you reconnect to a printer that is sd printing and also supports (or has been otherwise forced) connecting without resetig the machine. Clients who do this can send a M27 to check if an sd print is happening and seeing its response here (and if we not in busy we know this is the case) will then make atcore (and the client) act as if we have been watching that print all along.. the print time might be wrong but other wise correct data.

laysrodrigues added a subscriber: patrickelectric.
This revision is now accepted and ready to land.Jun 20 2018, 1:45 PM
rizzitello marked 2 inline comments as done.Jun 20 2018, 1:45 PM
rizzitello closed this revision.Jun 20 2018, 1:47 PM