Differential D13969

Change editor default view options
ClosedPublic
Actions

Authored by rizzitello on Jul 8 2018, 1:55 PM.

Details

Reviewers
leandrosantiago
laysrodrigues
tcanabrava
patrickelectric
Commits
R231:e46d8ac136ad: Change editor default view options
R231:68bb36e0e363: Change the editor default view options
Summary

The Defaults for the Gcode View have changed (these are only defaults user can change at run time)

  • Remove Line numbers: They get long and are visible on in the status area for those who need to see what line they are on, also could use jump to line.
  • Disable Dynamic Word Wrap: Gcode lines tend to be very short with out line numbers they almost always fit.
  • Disable the MiniMap Scrollbar - While that does make it easy to find a chunk in a normal document gcode files tend to just look like a block of lines so the visual overview is not very useful . This does not disable the scrollbar preview. If you put the cursor over a spot in the scrollbar you will still see a preview of the text there.
  • Enable Modification Markers: Unsaved changes are marked.
Test Plan

Before:


After:

Diff Detail

Repository
R231 Atelier
Branch
gcodeOptions
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 914
Build 927: arc lint + arc unit
rizzitello requested review of this revision.Jul 8 2018, 1:55 PM
rizzitello created this revision.
rizzitello updated this revision to Diff 37340.Jul 8 2018, 1:57 PM
  • Correct base
rizzitello retitled this revision from change configInterface default options to Change editor default view options.Jul 8 2018, 2:07 PM
rizzitello edited the summary of this revision. (Show Details)
rizzitello edited the test plan for this revision. (Show Details)
rizzitello added reviewers: leandrosantiago, laysrodrigues, tcanabrava, patrickelectric.
rizzitello added a project: Atelier: General Development.
rizzitello added subscribers: leandrosantiago, laysrodrigues, tcanabrava, patrickelectric.
tcanabrava accepted this revision.Jul 9 2018, 7:59 PM

That's better to read the configurations from disk rather than hard coding those values, unless I'm missing something.

This revision is now accepted and ready to land.Jul 9 2018, 7:59 PM
rizzitello updated this revision to Diff 37608.Jul 12 2018, 1:03 AM
rizzitello edited the summary of this revision. (Show Details)
  • Rebase
laysrodrigues added a comment.Jul 16 2018, 3:52 PM

I would like to have the line-numbers... the others modifications are fine.
Now based on @tcanabrava thoughts, this kind of profiling can be done on KTextEditor options on Atelier Settings->Configure Editor. Those can be just our 'default setup'.

rizzitello added a comment.Jul 16 2018, 4:52 PM
In D13969#293130, @laysrodrigues wrote:

I would like to have the line-numbers... the others modifications are fine.
Now based on @tcanabrava thoughts, this kind of profiling can be done on KTextEditor options on Atelier Settings->Configure Editor. Those can be just our 'default setup'.

I think we are missing a connect for the settings to be saved. If you open the configure dialog most options work now but a few do not. for instance with line numbers enabled in code you can't disable them again via the dialog.

rizzitello updated this revision to Diff 37894.Jul 16 2018, 4:55 PM
  • readd line numbers
rizzitello closed this revision.Jul 16 2018, 4:55 PM

Revision Contents
Changeset List

PathPackages
Msrc/widgets/gcodeeditorwidget.cpp (3 lines)

Diff 37894

View Options

src/widgets/gcodeeditorwidget.cpp

Loading...