Feed Advanced Search

Oct 12 2019

mlaurent added a comment to D24583: Remove Dependence on unistd.h and sys/time.h.

Just for info. Did you test it on linux too ?

Oct 12 2019, 10:07 AM · Craft, KDE Games
twighk requested review of D24589: Remove Include of unistd.h.
Oct 12 2019, 9:42 AM · Craft, KDE Games
twighk updated the summary of D24587: Fix struct Prototype of GameOptions.
Oct 12 2019, 9:25 AM · Craft, KDE Games
twighk requested review of D24587: Fix struct Prototype of GameOptions.
Oct 12 2019, 9:24 AM · Craft, KDE Games
twighk requested review of D24586: Remove Include of unistd.h.
Oct 12 2019, 8:47 AM · Craft, KDE Games
twighk requested review of D24583: Remove Dependence on unistd.h and sys/time.h.
Oct 12 2019, 8:28 AM · Craft, KDE Games
mlaurent accepted D24581: Restrict GNUGXX compiler options.
Oct 12 2019, 8:10 AM · KDE Games, Craft
twighk updated the summary of D24581: Restrict GNUGXX compiler options.
Oct 12 2019, 7:34 AM · KDE Games, Craft
twighk requested review of D24581: Restrict GNUGXX compiler options.
Oct 12 2019, 7:34 AM · KDE Games, Craft

Oct 11 2019

vonreth added a comment to D24570: Fix kolflib_export.

This will probably also break msvc.
I’d suggest reading the doc of cmake generate export macros.
The macros are often used wrong...

Oct 11 2019, 9:35 PM · Craft, KDE Games
yurchor added a comment to D24570: Fix kolflib_export.

Cannot be linked by ld with this patch on Linux.

Oct 11 2019, 9:18 PM · Craft, KDE Games
twighk requested review of D24573: Blueprint for Palapeli.
Oct 11 2019, 8:39 PM · KDE Games, Craft
twighk requested review of D24571: Blueprint for Kolf.
Oct 11 2019, 8:04 PM · KDE Games, Craft
twighk requested review of D24570: Fix kolflib_export.
Oct 11 2019, 8:00 PM · Craft, KDE Games
cullmann closed D24545: Add Some KDE Games to Craft Enabled Projects.

Created merge request for that

Oct 11 2019, 3:14 PM · KDE Games, Craft
cullmann closed D24421: Blueprint for KShisen.
Oct 11 2019, 3:10 PM · KDE Games, Craft
cullmann closed D24440: Add Blueprints for Dependencies for KPat.
Oct 11 2019, 3:10 PM · KDE Games, Craft

Oct 10 2019

aacid closed D24527: Add Icons To Executable.
Oct 10 2019, 10:31 PM · Craft, KDE Games
aacid accepted D24527: Add Icons To Executable.
Oct 10 2019, 10:30 PM · Craft, KDE Games
aacid closed D24526: Add Icons To Executable.
Oct 10 2019, 10:28 PM · Craft, KDE Games
aacid accepted D24526: Add Icons To Executable.
Oct 10 2019, 10:28 PM · Craft, KDE Games
aacid closed D24525: Add Icons To Executable.
Oct 10 2019, 10:25 PM · Craft, KDE Games
aacid accepted D24525: Add Icons To Executable.
Oct 10 2019, 10:24 PM · Craft, KDE Games
vonreth accepted D24546: Blueprint for KNavalBattle.
Oct 10 2019, 9:06 PM · KDE Games, Craft
vonreth accepted D24545: Add Some KDE Games to Craft Enabled Projects.

push once everything blueprint is merged

Oct 10 2019, 9:05 PM · KDE Games, Craft
vonreth accepted D24549: Blueprint for Picmi.
Oct 10 2019, 9:04 PM · KDE Games, Craft
vonreth accepted D24548: Blueprint for Kubrick.
Oct 10 2019, 9:04 PM · KDE Games, Craft
twighk updated the diff for D24546: Blueprint for KNavalBattle.

Remove dependency on libkmahjongg.

Oct 10 2019, 8:27 PM · KDE Games, Craft
twighk updated the diff for D24545: Add Some KDE Games to Craft Enabled Projects.

Change platform from mingw64 to win64.

Oct 10 2019, 8:24 PM · KDE Games, Craft
vonreth accepted D24547: Blueprint for KSudoku.
Oct 10 2019, 8:22 PM · KDE Games, Craft
twighk updated the diff for D24548: Blueprint for Kubrick.

remove dependency on libmahjongg

Oct 10 2019, 8:17 PM · KDE Games, Craft
twighk updated the diff for D24549: Blueprint for Picmi.

remove dependency on libkmahjongg

Oct 10 2019, 8:15 PM · KDE Games, Craft
twighk updated the diff for D24547: Blueprint for KSudoku.

remove libkmahjongg

Oct 10 2019, 8:13 PM · KDE Games, Craft
twighk added a comment to D24547: Blueprint for KSudoku.

Ah sorry, i was using that as my base for copy pasting. It's probably not a dependancy.

Oct 10 2019, 8:10 PM · KDE Games, Craft
twighk requested review of D24549: Blueprint for Picmi.
Oct 10 2019, 8:05 PM · KDE Games, Craft
vonreth added a comment to D24547: Blueprint for KSudoku.

Why does everything depend on libkmahjongg? If that correct maybe the lib should be renamed 😅

Oct 10 2019, 8:04 PM · KDE Games, Craft
vonreth added a comment to D24545: Add Some KDE Games to Craft Enabled Projects.

As @cullmann said, msvc is the main supported compiler, qts support for mingw is limited.
Please try msvc where possible.

Oct 10 2019, 8:03 PM · KDE Games, Craft
vonreth accepted D24548: Blueprint for Kubrick.
Oct 10 2019, 8:01 PM · KDE Games, Craft
twighk requested review of D24548: Blueprint for Kubrick.
Oct 10 2019, 8:01 PM · KDE Games, Craft
vonreth added inline comments to D24250: Add Krusader to Craft.
Oct 10 2019, 7:59 PM · Craft
vonreth accepted D24421: Blueprint for KShisen.
Oct 10 2019, 7:59 PM · KDE Games, Craft
vonreth accepted D24440: Add Blueprints for Dependencies for KPat.
Oct 10 2019, 7:58 PM · KDE Games, Craft
vonreth added a comment to D24440: Add Blueprints for Dependencies for KPat.

looks good, msvc issues can be fixed later.

Oct 10 2019, 7:58 PM · KDE Games, Craft
twighk requested review of D24547: Blueprint for KSudoku.
Oct 10 2019, 7:57 PM · KDE Games, Craft
twighk updated the summary of D24546: Blueprint for KNavalBattle.
Oct 10 2019, 7:57 PM · KDE Games, Craft
twighk requested review of D24546: Blueprint for KNavalBattle.
Oct 10 2019, 7:48 PM · KDE Games, Craft
cullmann added a comment to D24545: Add Some KDE Games to Craft Enabled Projects.

I think it would make more sense to first try this with the native msvc compiler, aka win64 as platform.
We can later still revert back to using mingw64 if that fails.

Oct 10 2019, 7:45 PM · KDE Games, Craft
twighk requested review of D24545: Add Some KDE Games to Craft Enabled Projects.
Oct 10 2019, 7:37 PM · KDE Games, Craft
cullmann added a comment to D24440: Add Blueprints for Dependencies for KPat.

You can do that via merge request to

Oct 10 2019, 8:57 AM · KDE Games, Craft
twighk added a comment to D24440: Add Blueprints for Dependencies for KPat.

Overall: As you seem to be interested in getting KDE games running on Windows, shall we add some jobs to binary-factory.kde.org for Windows compiles?
Then you can take a look there if all works nicely.

Oct 10 2019, 8:37 AM · KDE Games, Craft
cullmann added a reviewer for D24440: Add Blueprints for Dependencies for KPat: vonreth.

Hannah can give perhaps some short feedback.

Oct 10 2019, 6:57 AM · KDE Games, Craft

Oct 9 2019

twighk added a comment to D24444: Remove KDEGAMES_EXPORT.

Nice patch.

I see you've been working on getting things compiling on Windows, nice work :)

Do you know of the initiative we have for getting some applications to the Windows Store? Want to join?

Oct 9 2019, 7:49 PM · KDE Games, Craft
twighk requested review of D24527: Add Icons To Executable.
Oct 9 2019, 7:44 PM · Craft, KDE Games
twighk requested review of D24526: Add Icons To Executable.
Oct 9 2019, 7:30 PM · Craft, KDE Games
twighk requested review of D24525: Add Icons To Executable.
Oct 9 2019, 7:23 PM · Craft, KDE Games

Oct 7 2019

aacid closed D24435: Fix Blueprint description for KPat.
Oct 7 2019, 9:20 PM · KDE Games, Craft
aacid accepted D24435: Fix Blueprint description for KPat.

I've not much idea about craft, but this seems like a no brainer, so landing it :)

Oct 7 2019, 9:19 PM · KDE Games, Craft
aacid closed D24444: Remove KDEGAMES_EXPORT.
Oct 7 2019, 9:17 PM · KDE Games, Craft
aacid accepted D24444: Remove KDEGAMES_EXPORT.

Nice patch.

Oct 7 2019, 9:16 PM · KDE Games, Craft
aacid closed D24441: Remove Include of pwd.h from kexthighscore_internal.cpp.
Oct 7 2019, 9:12 PM · KDE Games, Craft

Oct 6 2019

twighk requested review of D24444: Remove KDEGAMES_EXPORT.
Oct 6 2019, 3:08 PM · KDE Games, Craft
yurchor accepted D24441: Remove Include of pwd.h from kexthighscore_internal.cpp.

Compiles fine in Linux without that include. Thanks.

Oct 6 2019, 2:48 PM · KDE Games, Craft
twighk requested review of D24441: Remove Include of pwd.h from kexthighscore_internal.cpp.
Oct 6 2019, 12:58 PM · KDE Games, Craft
twighk requested review of D24440: Add Blueprints for Dependencies for KPat.
Oct 6 2019, 11:42 AM · KDE Games, Craft
aacid closed D24420: Compile error on conversion of std::time_t to long int.
Oct 6 2019, 11:22 AM · Craft, KDE Games
twighk requested review of D24435: Fix Blueprint description for KPat.
Oct 6 2019, 9:24 AM · KDE Games, Craft

Oct 5 2019

twighk added a reviewer for D24421: Blueprint for KShisen: vonreth.
Oct 5 2019, 10:26 AM · KDE Games, Craft
twighk requested review of D24421: Blueprint for KShisen.
Oct 5 2019, 10:14 AM · KDE Games, Craft
yurchor accepted D24420: Compile error on conversion of std::time_t to long int.
Oct 5 2019, 9:29 AM · Craft, KDE Games
twighk updated the diff for D24420: Compile error on conversion of std::time_t to long int.
Oct 5 2019, 9:28 AM · Craft, KDE Games
yurchor added a comment to D24420: Compile error on conversion of std::time_t to long int.

Works fine in Linux.

Oct 5 2019, 9:25 AM · Craft, KDE Games
twighk requested review of D24420: Compile error on conversion of std::time_t to long int.
Oct 5 2019, 9:13 AM · Craft, KDE Games

Sep 26 2019

gengisdave requested review of D24250: Add Krusader to Craft.
Sep 26 2019, 7:26 PM · Craft

Sep 23 2019

rizzitello closed D24143: Upate AtCore/ Atelier.
Sep 23 2019, 12:22 PM · Atelier: General Development, Craft
rizzitello updated the diff for D24143: Upate AtCore/ Atelier.
  • rebase Before landing
Sep 23 2019, 12:21 PM · Atelier: General Development, Craft
rizzitello added a comment to D24143: Upate AtCore/ Atelier.

I have to wait for https://invent.kde.org/kde/atelier/merge_requests/2 to land before landing this.

Sep 23 2019, 2:09 AM · Atelier: General Development, Craft
rizzitello updated the diff for D24143: Upate AtCore/ Atelier.
  • update Icons
Sep 23 2019, 2:07 AM · Atelier: General Development, Craft

Sep 22 2019

vonreth accepted D24143: Upate AtCore/ Atelier.

looks sane

Sep 22 2019, 3:31 PM · Atelier: General Development, Craft
rizzitello added projects to D24143: Upate AtCore/ Atelier: Craft, Atelier: General Development.
Sep 22 2019, 1:38 PM · Atelier: General Development, Craft

Sep 18 2019

brute4s99 added a comment to D23906: add password as a config option in Appx Package signing .

I for one use this :)

Sep 18 2019, 11:30 PM · Craft
brute4s99 closed D24032: add auto start to KDE Connect Blueprint.
Sep 18 2019, 11:29 PM · Craft, KDE Connect
brute4s99 updated the diff for D24032: add auto start to KDE Connect Blueprint.

rebase

Sep 18 2019, 11:27 PM · Craft, KDE Connect
brute4s99 closed D23907: add support for auto start in appx packages.
Sep 18 2019, 11:25 PM · Craft

Sep 17 2019

brute4s99 requested review of D24032: add auto start to KDE Connect Blueprint.
Sep 17 2019, 6:54 PM · Craft, KDE Connect
brute4s99 added a comment to D23907: add support for auto start in appx packages.

rebased

Sep 17 2019, 6:34 PM · Craft
brute4s99 updated the diff for D23907: add support for auto start in appx packages.
Sep 17 2019, 6:34 PM · Craft
brute4s99 added a comment to D23907: add support for auto start in appx packages.

I'm unable to land D23907, please take a look when you can.

Sep 17 2019, 6:33 PM · Craft
vonreth accepted D23907: add support for auto start in appx packages.
Sep 17 2019, 2:16 PM · Craft

Sep 12 2019

brute4s99 requested review of D23907: add support for auto start in appx packages.
Sep 12 2019, 2:05 PM · Craft
brute4s99 requested review of D23906: add password as a config option in Appx Package signing .
Sep 12 2019, 2:01 PM · Craft

Aug 19 2019

brute4s99 closed D23209: add images to KDE Connect .Appx build.
Aug 19 2019, 8:28 PM · Craft, KDE Connect
brute4s99 added a comment to D23209: add images to KDE Connect .Appx build.

landing it!

a duckling

Aug 19 2019, 8:28 PM · Craft, KDE Connect
vonreth accepted D23209: add images to KDE Connect .Appx build.

looks good

Aug 19 2019, 8:21 PM · Craft, KDE Connect
brute4s99 updated the diff for D23209: add images to KDE Connect .Appx build.
Aug 19 2019, 8:09 PM · Craft, KDE Connect
vonreth requested changes to D23209: add images to KDE Connect .Appx build.
Aug 19 2019, 7:19 PM · Craft, KDE Connect

Aug 16 2019

brute4s99 requested review of D23209: add images to KDE Connect .Appx build.
Aug 16 2019, 9:42 PM · Craft, KDE Connect

Jul 5 2019

brute4s99 closed D21658: add snoretoast for win32 builds to knotifs blueprint.
Jul 5 2019, 3:24 PM · Craft
albertvaka accepted D21658: add snoretoast for win32 builds to knotifs blueprint.

Sure, you've got 2 approvals (3 now).

Jul 5 2019, 1:01 PM · Craft

Jul 3 2019

brute4s99 added a comment to D21658: add snoretoast for win32 builds to knotifs blueprint.

should I land this?

Jul 3 2019, 6:23 PM · Craft
brute4s99 closed D21602: Add NSIS Script for KDE Connect.
Jul 3 2019, 10:33 AM · Craft, KDE Connect