Differential D24545

Add Some KDE Games to Craft Enabled Projects
ClosedPublic
Actions

Authored by twighk on Oct 10 2019, 7:37 PM.

Details

Reviewers
cullmann
vonreth
Summary

Added KDE Games in craft(+kshisen) to craft/enabled-projects.yaml

kpat: Likely to fail compilation due to dependancy issues D24440: Add Blueprints for Dependencies for KPat
kshisen: Will fail as blueprint not yet in craft D24421: Blueprint for KShisen

Sorry, i haven't tested this patch so don't know how many mistakes there are, as i don't have the build system set-up locally. (Random yaml validator online said it was valid yaml).

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
twighk requested review of this revision.Oct 10 2019, 7:37 PM
twighk created this revision.
cullmann added a comment.Oct 10 2019, 7:45 PM

I think it would make more sense to first try this with the native msvc compiler, aka win64 as platform.
We can later still revert back to using mingw64 if that fails.

vonreth added a subscriber: vonreth.Oct 10 2019, 8:03 PM

As @cullmann said, msvc is the main supported compiler, qts support for mingw is limited.
Please try msvc where possible.

twighk updated this revision to Diff 67651.Oct 10 2019, 8:24 PM

Change platform from mingw64 to win64.

vonreth accepted this revision.Oct 10 2019, 9:05 PM

push once everything blueprint is merged

This revision is now accepted and ready to land.Oct 10 2019, 9:05 PM
cullmann closed this revision.Oct 11 2019, 3:14 PM

Created merge request for that

https://invent.kde.org/sysadmin/binary-factory-tooling/merge_requests/21

The binary factory tooling is managed on invent.kde.org.

Revision Contents
Changeset List

PathPackages
Mcraft/enabled-projects.yaml (204 lines)

Diff 67651

View Options

craft/enabled-projects.yaml

Loading...