Remove Dependence on unistd.h and sys/time.h
ClosedPublic
Actions

Authored by twighk on Oct 12 2019, 8:28 AM.

Details

Reviewers

cullmann
aacid

Group Reviewers

KDE Games

Commits

Summary

Removed unistd.h and sys/time.h, and refactored getMillisecOfNow() as appeared to be duplicated code.

Compiles with MSVC using craft.

Repository

R391 KBlocks

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript

twighk requested review of this revision.Oct 12 2019, 8:28 AM

Just for info. Did you test it on linux too ?

In D24583#545943, @mlaurent wrote:

Just for info. Did you test it on linux too ?

No. Sorry, i only tested it on windows.

Copied the diff to test on linux

It builds and runs on my linux box. I couldn't work out how to get the previous patch to apply, so remade it.

Looks reasonable for me, and should be C++11 API.

This revision is now accepted and ready to land.Oct 12 2019, 4:19 PM

aacid added inline comments.

utils.h
6	i'm a bit unhappy with a floating function here. Would be happier if it was inside a namespace Utils {} What do you think?

The code is too C++-y to me, but it works :D

On the other hand since this is a relatively "big" change i think this should just go to master and not to Applications/19.08

This revision was automatically updated to reflect the committed changes.

twighk marked an inline comment as done.

		Path
M		AI/KBlocksAITypeDefine.h (2 lines)
M		CMakeLists.txt (1 line)
M		KBlocksConfigManager.cpp (1 line)
M		KBlocksGameRecorder.h (2 lines)
M		KBlocksGameRecorder.cpp (16 lines)
M		KBlocksSingleGame.h (3 lines)
M		KBlocksSingleGame.cpp (21 lines)
A	M	utils.h (9 lines)
A	M	utils.cpp (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	67770			Oct 12 2019, 8:26 AM	★	★
Diff 2	67795	b045ace	Copied the diff to test on linux	Oct 12 2019, 3:23 PM	★	★
Diff 3	67859	b045ace	- Put utils in namespace.	Oct 13 2019, 5:52 PM	★	★
Diff 4	68202	b045ace	R391:2b129609e926380ab12821ad9c0fc082c1f6f651	Oct 17 2019, 5:16 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
fb281ecea0b0	cd454b4f2c69	7603dde541b1	twighk	Put utils in namespace.	Oct 13 2019, 5:51 PM
7603dde541b1	c7d1e54562b3	b045ace57425	twighk	Remove Dependence on unistd.h and sys/time.h (Show More…)	Oct 12 2019, 3:22 PM