Compile error on conversion of std::time_t to long int
ClosedPublic
Actions

Authored by twighk on Oct 5 2019, 9:13 AM.

Details

Reviewers

yurchor

Group Reviewers

KDE Games

Commits

R396:be77f2fe56bb: Fix compile error on Windows

Summary

Compile error with craft on windows using mingw compiler

C:/CraftRoot/build/_/7971cb53/kgoldrunner-19.08.1/src/kgrgame.cpp:118:56: error: call of overloaded 'KRandomSequence(time_t)' is ambiguous

randomGen = new KRandomSequence (std::time(nullptr));
                                                   ^

In file included from C:/CraftRoot/include/KF5/KCoreAddons/KRandomSequence:1,

from C:/CraftRoot/build/_/7971cb53/kgoldrunner-19.08.1/src/kgrgame.cpp:59:

C:/CraftRoot/include/KF5/KCoreAddons/krandomsequence.h:70:5: note: candidate: 'KRandomSequence::KRandomSequence(const KRandomSequence&)'

KRandomSequence(const KRandomSequence &a);
^~~~~~~~~~~~~~~

C:/CraftRoot/include/KF5/KCoreAddons/krandomsequence.h:60:14: note: candidate: 'KRandomSequence::KRandomSequence(long int)'

explicit KRandomSequence(long lngSeed);
         ^~~~~~~~~~~~~~~

C:/CraftRoot/include/KF5/KCoreAddons/krandomsequence.h:59:14: note: candidate: 'KRandomSequence::KRandomSequence(int)'

explicit KRandomSequence(int intSeed = 0);
         ^~~~~~~~~~~~~~~

Repository

R396 KGoldrunner

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

twighk requested review of this revision.Oct 5 2019, 9:13 AM

Works fine in Linux.

kgoldrunner-19.08.1/src/kgrgame.cpp
119 ↗	(On Diff #67338)	May it be the typo ("sead" -> "seed")?

This revision is now accepted and ready to land.Oct 5 2019, 9:29 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/kgrgame.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	67338			Oct 5 2019, 9:06 AM	★	★
Diff 2	67339			Oct 5 2019, 9:28 AM	★	★
Diff 3	67370	7e8c225	R396:be77f2fe56bb7006a131de1cd8838ff6c8169cf5	Oct 6 2019, 11:21 AM	★	★