Jun 13 2019
Yes, I re-read the KF5 porting notes and I guess the KFoo -> QFoo thingy was a misconception based on the deprecation of quite some the KDE 4 KFoo classes.
Thanks for your comments. :)
Jun 12 2019
Depends, KUrl? Yes Kurl is deprecated and you should use QUrl
Hmm, that was exactly my thought when I saw these Krazy issues. I think to remember exactly the opposite suggestion from a few years ago where Krazy said, we should use the equivalent Qt classes. Am I remembering correctly?
Jun 11 2019
at this point i'd say that krazy warning is a bit old fashioned, but sure, won't hurt either
May 4 2019
If checked closely, the values are essentially handled well, because the values which will get converted to symbols are limited and therefore the values to be converted back would be limited as well. Hence, it will not produce unexpected results.
May 1 2019
Do you have commit access or you want that we commit for you ?
Apr 30 2019
for me it's ok.
Forget to commit last changes
Apr 29 2019
Apr 28 2019
Apr 26 2019
Change to KStandardAction & Revision increase in rc file
Apr 25 2019
Apr 2 2019
Apr 1 2019
Jan 17 2019
https://phabricator.kde.org/D17860 has been committed.
Jan 1 2019
Updated. I'm not using arcanist... I suppose I should bug the mailing list every so often?
Dec 29 2018
Also, it is extremely unpractical to get a review through a task - they are not meant for this. Please close this and send a review.
I'd really suggest to use arcanist and send a patch. Commit to the local repository, arc diff, and that's it, the kdegames mailing list will be notified.
Dec 20 2018
diff --git a/cellitem.cpp b/cellitem.cpp index b4e3060..443b743 100644 --- a/cellitem.cpp +++ b/cellitem.cpp @@ -33,6 +33,17 @@ CellItem::CellItem(KGameRenderer* renderer, QGraphicsItem* parent) reset(); }
Not really sure how to use all your tooling (way, way too complicated, doesn't work/breaks).
Oct 21 2018
Sep 24 2018
Removed the uncessary localization update since that has been fixed elsewhere and renamed the revision to make it clear it's just about OARS now
Sep 21 2018
(this specific change is going to be only about adding the oars tag)
But then the commit message should be fixed, and also the german change removed.
The german translation part should go to @kde-i18n-de. Will reach out.
Sep 4 2018
No need for being sorry :) it's just that the unified issue tracker is there.
Tasks can be created later from bugs, depending on the team.
Thanks for reporting the issue.