KDE GamesProject
ActivePublic

Recent Activity

Jun 13 2019

schwarzer abandoned D21756: Replace QMessageBox by KMessageBox.

Committed in 1e656e0051f3919b02f8425632d47f9d332785ab
https://cgit.kde.org/kshisen.git/commit/?id=1e656e0051f3919b02f8425632d47f9d332785ab

Jun 13 2019, 10:11 PM · KDE Games
schwarzer added a comment to D21756: Replace QMessageBox by KMessageBox.

Yes, I re-read the KF5 porting notes and I guess the KFoo -> QFoo thingy was a misconception based on the deprecation of quite some the KDE 4 KFoo classes.
Thanks for your comments. :)

Jun 13 2019, 9:44 PM · KDE Games

Jun 12 2019

aacid added a comment to D21756: Replace QMessageBox by KMessageBox.

Depends, KUrl? Yes Kurl is deprecated and you should use QUrl

Jun 12 2019, 8:30 PM · KDE Games
schwarzer added a comment to D21756: Replace QMessageBox by KMessageBox.

Hmm, that was exactly my thought when I saw these Krazy issues. I think to remember exactly the opposite suggestion from a few years ago where Krazy said, we should use the equivalent Qt classes. Am I remembering correctly?

Jun 12 2019, 8:53 AM · KDE Games

Jun 11 2019

aacid added a comment to D21756: Replace QMessageBox by KMessageBox.

at this point i'd say that krazy warning is a bit old fashioned, but sure, won't hurt either

Jun 11 2019, 10:08 PM · KDE Games
schwarzer requested review of D21756: Replace QMessageBox by KMessageBox.
Jun 11 2019, 10:04 PM · KDE Games

May 4 2019

khanaasif closed T5979: Sudoku: make sure to handle out-of-range characters in Symbols as Resolved.
May 4 2019, 9:33 PM · KDE Games
khanaasif added a comment to T5979: Sudoku: make sure to handle out-of-range characters in Symbols.

If checked closely, the values are essentially handled well, because the values which will get converted to symbols are limited and therefore the values to be converted back would be limited as well. Hence, it will not produce unexpected results.

May 4 2019, 9:32 PM · KDE Games
krippendorf closed D20831: Add fullscreen mode to kmahjongg.
May 4 2019, 11:16 AM · KDE Games

May 1 2019

krippendorf added a comment to D20831: Add fullscreen mode to kmahjongg.

Do you have commit access or you want that we commit for you ?

May 1 2019, 7:39 PM · KDE Games
mlaurent added a comment to D20831: Add fullscreen mode to kmahjongg.

Do you have commit access or you want that we commit for you ?

May 1 2019, 8:17 AM · KDE Games

Apr 30 2019

aacid accepted D20831: Add fullscreen mode to kmahjongg.
Apr 30 2019, 9:35 PM · KDE Games
mlaurent accepted D20831: Add fullscreen mode to kmahjongg.

for me it's ok.

Apr 30 2019, 12:05 PM · KDE Games
krippendorf updated the diff for D20831: Add fullscreen mode to kmahjongg.

Forget to commit last changes

Apr 30 2019, 12:05 PM · KDE Games
krippendorf updated the diff for D20831: Add fullscreen mode to kmahjongg.
Apr 30 2019, 12:01 PM · KDE Games

Apr 29 2019

mlaurent requested changes to D20831: Add fullscreen mode to kmahjongg.
Apr 29 2019, 4:48 AM · KDE Games

Apr 28 2019

krippendorf updated the diff for D20831: Add fullscreen mode to kmahjongg.
Apr 28 2019, 1:26 PM · KDE Games

Apr 26 2019

mlaurent requested changes to D20831: Add fullscreen mode to kmahjongg.
Apr 26 2019, 11:17 AM · KDE Games
krippendorf updated the diff for D20831: Add fullscreen mode to kmahjongg.

Change to KStandardAction & Revision increase in rc file

Apr 26 2019, 7:23 AM · KDE Games
mlaurent requested changes to D20831: Add fullscreen mode to kmahjongg.
Apr 26 2019, 6:04 AM · KDE Games

Apr 25 2019

aacid added inline comments to D20831: Add fullscreen mode to kmahjongg.
Apr 25 2019, 9:23 PM · KDE Games
krippendorf requested review of D20831: Add fullscreen mode to kmahjongg.
Apr 25 2019, 8:43 PM · KDE Games
krippendorf added a watcher for KDE Games: krippendorf.
Apr 25 2019, 5:21 PM

Apr 2 2019

patrickelectric closed D20187: add .arcconfig file.
Apr 2 2019, 9:05 PM · KDE Games
andreagenor added a comment to D20187: add .arcconfig file.

@patrickelectric @andreagenor will one of you commti this?

Apr 2 2019, 7:29 AM · KDE Games

Apr 1 2019

aacid added a comment to D20187: add .arcconfig file.

@patrickelectric @andreagenor will one of you commti this?

Apr 1 2019, 9:40 PM · KDE Games
patrickelectric accepted D20187: add .arcconfig file.
Apr 1 2019, 9:25 PM · KDE Games
andreagenor accepted D20187: add .arcconfig file.
Apr 1 2019, 9:17 PM · KDE Games
andreagenor added a comment to D20187: add .arcconfig file.
Apr 1 2019, 9:11 PM · KDE Games
andreagenor added a project to D20187: add .arcconfig file: KDE Games.
Apr 1 2019, 9:08 PM · KDE Games

Jan 17 2019

cfeck closed T10205: Allow User to Reset KMines Game on game over as Resolved.

https://phabricator.kde.org/D17860 has been committed.

Jan 17 2019, 5:23 AM · KDE Games

Jan 1 2019

ltoscano added a comment to T10205: Allow User to Reset KMines Game on game over.

https://phabricator.kde.org/D17860

Updated. I'm not using arcanist... I suppose I should bug the mailing list every so often?

Jan 1 2019, 4:30 PM · KDE Games
smaudet added a comment to T10205: Allow User to Reset KMines Game on game over.

Updated. I'm not using arcanist... I suppose I should bug the mailing list every so often?

Jan 1 2019, 4:08 PM · KDE Games

Dec 29 2018

ltoscano added a comment to T10205: Allow User to Reset KMines Game on game over.

Also, it is extremely unpractical to get a review through a task - they are not meant for this. Please close this and send a review.

Dec 29 2018, 10:21 AM · KDE Games
ltoscano added a comment to T10205: Allow User to Reset KMines Game on game over.

I'd really suggest to use arcanist and send a patch. Commit to the local repository, arc diff, and that's it, the kdegames mailing list will be notified.

Dec 29 2018, 10:19 AM · KDE Games

Dec 20 2018

smaudet added a comment to T10205: Allow User to Reset KMines Game on game over.

SRPM:
https://mega.nz/#!HKAxHIra!3nqFSDIZ74fPn7H-fhu4jy3tpVl43GqxmIOzD14p5Eg
RPM:
https://mega.nz/#!rDBXlKYI!3gXR8uPyhJTBP2wh4ePw2uirJIzjMwwfxif5VAwBLQk

Dec 20 2018, 11:41 AM · KDE Games
smaudet added a comment to T10205: Allow User to Reset KMines Game on game over.
diff --git a/cellitem.cpp b/cellitem.cpp
index b4e3060..443b743 100644
--- a/cellitem.cpp
+++ b/cellitem.cpp
@@ -33,6 +33,17 @@ CellItem::CellItem(KGameRenderer* renderer, QGraphicsItem* parent)
     reset();
 }
Dec 20 2018, 11:33 AM · KDE Games
smaudet added a comment to T10205: Allow User to Reset KMines Game on game over.

Not really sure how to use all your tooling (way, way too complicated, doesn't work/breaks).

Dec 20 2018, 11:32 AM · KDE Games
smaudet triaged T10205: Allow User to Reset KMines Game on game over as Low priority.
Dec 20 2018, 11:26 AM · KDE Games

Oct 21 2018

ltoscano closed D15641: Add OARS to Kubrick.
Oct 21 2018, 2:35 PM · KDE Games

Sep 24 2018

ltoscano accepted D15641: Add OARS to Kubrick.

Thanks!

Sep 24 2018, 9:18 AM · KDE Games
nickrichards updated the diff for D15641: Add OARS to Kubrick.

Removed the uncessary localization update since that has been fixed elsewhere and renamed the revision to make it clear it's just about OARS now

Sep 24 2018, 9:07 AM · KDE Games

Sep 21 2018

ltoscano added a comment to D15641: Add OARS to Kubrick.

(this specific change is going to be only about adding the oars tag)

Sep 21 2018, 10:03 AM · KDE Games
ltoscano requested changes to D15641: Add OARS to Kubrick.

But then the commit message should be fixed, and also the german change removed.

Sep 21 2018, 10:02 AM · KDE Games
nickrichards added a comment to D15641: Add OARS to Kubrick.

Thanks!

Sep 21 2018, 9:53 AM · KDE Games
apol accepted D15641: Add OARS to Kubrick.

The german translation part should go to @kde-i18n-de. Will reach out.

Sep 21 2018, 9:51 AM · KDE Games
nickrichards requested review of D15641: Add OARS to Kubrick.
Sep 21 2018, 9:49 AM · KDE Games

Sep 4 2018

ltoscano added a comment to T9621: Klickety - install the appdata.

No need for being sorry :) it's just that the unified issue tracker is there.
Tasks can be created later from bugs, depending on the team.
Thanks for reporting the issue.

Sep 4 2018, 7:51 PM · KDE Games
ltoscano closed T9621: Klickety - install the appdata as Resolved by committing R401:d1fbba470ff1: Install the appdata files and fix few metadata.
Sep 4 2018, 7:49 PM · KDE Games
nickrichards added a comment to T9621: Klickety - install the appdata.

Apologies.

Sep 4 2018, 7:44 PM · KDE Games