Mon, Oct 28
Sun, Oct 20
Ok, i have removed the arcpatch-D24745 branch from the git repo.
That would have been a mistake, as i'm not completely sure on what i'm doing.
Any reason you commited the arcpatch-D24745 branch to git?
Sat, Oct 19
Submitted merge request:
Fri, Oct 18
Remove extra flags
Overall the description could be a bit more verbose (explain what kind of game it is :D )
Thu, Oct 17
-Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -fno-exceptions are added by default by ecm so it's not that even we need to list them here.
Oct 13 2019
The code is too C++-y to me, but it works :D
- Put utils in namespace.
Do you have some developer account to push that yourself? If not, I would go for applying for one, as you seem to care for this stuff and it will be much easier if you can push on your own.
Looks reasonable for me.
Remove KOLFLIB_EXPORT and make kolfprivate library static.
Oct 12 2019
If we're going to make the kolfprivate library to be static, which kind of makes sense since we don't install the includes anyway
This is wrong, these classes are part of a public library, they need the symbols to be exported
Instead of removing KOLFLIB_EXPORT, set a define when building it so it choses the correct dll linkage.
Looks reasonable for me, and should be C++11 API.