I think I simply forgot to close this long ago.

Ok, i have removed the arcpatch-D24745 branch from the git repo.

That would have been a mistake, as i'm not completely sure on what i'm doing.

Any reason you commited the arcpatch-D24745 branch to git?

Submitted merge request:
https://invent.kde.org/sysadmin/binary-factory-tooling/merge_requests/26

Remove extra flags

Overall the description could be a bit more verbose (explain what kind of game it is :D )

-Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -fno-exceptions are added by default by ecm so it's not that even we need to list them here.

The code is too C++-y to me, but it works :D

• Put utils in namespace.

In D24570#546413, @cullmann wrote:

Do you have some developer account to push that yourself? If not, I would go for applying for one, as you seem to care for this stuff and it will be much easier if you can push on your own.

Do you have some developer account to push that yourself? If not, I would go for applying for one, as you seem to care for this stuff and it will be much easier if you can push on your own.

Looks reasonable for me.

Remove KOLFLIB_EXPORT and make kolfprivate library static.

If we're going to make the kolfprivate library to be static, which kind of makes sense since we don't install the includes anyway

This is wrong, these classes are part of a public library, they need the symbols to be exported