this also contributes to fixing the kdeconnect windows builds on the factory.

pushed the commit directly.

added exception for CI mode packaging

Please create a related pr to change the usage in the kate blueprint

hid the logged command for signing when password protection is used for signing.

1. What's new?

I have re-implemented the patch, so the CLI asks for password at every sign() call.

ah, right. Cleartext password thing didn't cross my mind.

I won't accept this change.
Saving a password in config file offers some risk.
Also if its a self signed cert for testing, just create one without pw.

@vonreth mayI land this? :)

Ok, i have removed the arcpatch-D24745 branch from the git repo.

That would have been a mistake, as i'm not completely sure on what i'm doing.

Any reason you commited the arcpatch-D24745 branch to git?

Submitted merge request:
https://invent.kde.org/sysadmin/binary-factory-tooling/merge_requests/26

Remove extra flags

Overall the description could be a bit more verbose (explain what kind of game it is :D )

-Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -fno-exceptions are added by default by ecm so it's not that even we need to list them here.

The code is too C++-y to me, but it works :D

• Put utils in namespace.

In D24570#546413, @cullmann wrote:

Do you have some developer account to push that yourself? If not, I would go for applying for one, as you seem to care for this stuff and it will be much easier if you can push on your own.

Do you have some developer account to push that yourself? If not, I would go for applying for one, as you seem to care for this stuff and it will be much easier if you can push on your own.

Looks reasonable for me.

Remove KOLFLIB_EXPORT and make kolfprivate library static.

If we're going to make the kolfprivate library to be static, which kind of makes sense since we don't install the includes anyway

Instead of removing KOLFLIB_EXPORT, set a define when building it so it choses the correct dll linkage.

Looks reasonable for me, and should be C++11 API.

It builds and runs on my linux box. I couldn't work out how to get the previous patch to apply, so remade it.

Copied the diff to test on linux

In D24583#545943, @mlaurent wrote:

Just for info. Did you test it on linux too ?