• Merge branch 'master' into open_multiple_files
• Display open selected files menu entry on folder containing a unique item

In D15284#321501, @huftis wrote:

If ‘Hide completed items’ is checked and one right-clicks on a folder and selects ‘Open selected files’, all files in the folder are opened. The expected behaviour would be to open just the incomplete files.

If ‘Hide completed items’ is checked and one right-clicks on a folder and selects ‘Open selected files’, all files in the folder are opened. The expected behaviour would be to open just the incomplete files.

• Merge master
• Merge branch 'master' into open_multiple_files

In D14936#320638, @dfaure wrote:

So each tab has its own KActionCollection, but with the same action names as the other tabs?

So each tab has its own KActionCollection, but with the same action names as the other tabs?

Replace isNotDir by isFile + add const

Fix a discrepency between used timestamps

Fix legacy data reader

Versioning of binary data + const

If there are no comments I will move forward with this change tomorrow

The thing is that to me it doesn't feel like guiClient()->reloadXML(); manually, i would expect KXmlGui & friends just to handle this properly.

In D14936#313721, @aacid wrote:

I'm a bit lost, can you explain what's the problem with a bit more verbosity?

I'm a bit lost, can you explain what's the problem with a bit more verbosity?

I never questioned the direct access to SVN, which is a central requirement and it is not prevented by the usage of that website.

Update editorui.rc name

Well, I always said that DamnedLies is much better than anything eles (Pootle/Transifex/Weblate/etc), but I think we need to keep normal SVN access available as we have lots of file in KDE that are just few strings, and the whole process of downloading translating uploading for each one will be a huge headache :)

• Merge branch 'master' into delete_shortcut_tm

Cleanup of spacing

Amended singleShot calls 2

Amended singleShot calls

Mapping newly created signal

... and also few other branches, so all scripts/ directory under:

The most interesting candidate is Damned Lies from Gnome:
https://wiki.gnome.org/DamnedLies

Change for the new connect signal

In D14683#307949, @aacid wrote:

This seems very corner casey and i'm afraid we may be adding too much menu entries, but ok.

In D14573#307963, @aacid wrote:

Maybe Ctrl+Shift instead of Ctrl+Alt?

Shift is commonly used to say "the reverse", for example in kate Ctrl+D commends and Ctrl+Shift+D uncomments

Maybe Ctrl+Shift instead of Ctrl+Alt?

This seems very corner casey and i'm afraid we may be adding too much menu entries, but ok.

Put the ternary condition in a variable

Const variables

looks good, if you can please add const to all those variables.

Looks good to me, if you want, maybe it makes sense to put

Zero is positive

Simplified test

In D14703#305913, @aacid wrote:

What to link https://www.kde.org/applications/development/lokalize/ ?

I've added the link on the bold Lokalize in the intro

Fix typo + link on title

What to link https://www.kde.org/applications/development/lokalize/ ?

One small fix inline:

Seems ok for me

In D10009#303703, @aacid wrote:

Simon what do you think about this?

Fixing patch

Simon what do you think about this?

In D10009#280343, @aacid wrote:

Can you please explain the code changes?

Since this turned already into a discussion, shall we use %Lx version for KF5 libraries using Qt's translation system? I mean in the source text.

Remove unrelated warning

I've initiated the values.

Initialize variables

Disable word wrap at or below 3 characters

Fix a bug in the \\ escaping

In D14311#300531, @huftis wrote:

I hadn’t have a chance to take a look at this before now. The feature for disabling word-wrapping is very welcome (it will lead to much cleaner SVN diffs), but the word-wrapping in general seems buggy for small (positive) numbers. If I set the word-wrapping to 3 and save the PO file (I tested this with lokalize.po), Lokalize promptly 1) deletes to contents of the PO file, 2) starts using 100% CPU and eating more and more memory, until 3) my system runs out of memory and freezes/crashes (needing a hard reboot).

I hadn’t have a chance to take a look at this before now. The feature for disabling word-wrapping is very welcome (it will lead to much cleaner SVN diffs), but the word-wrapping in general seems buggy for small (positive) numbers. If I set the word-wrapping to 3 and save the PO file (I tested this with lokalize.po), Lokalize promptly 1) deletes to contents of the PO file, 2) starts using 100% CPU and eating more and more memory, until 3) my system runs out of memory and freezes/crashes (needing a hard reboot).