Differential D14703

Add a README.md with some info for Github and Phabricator
ClosedPublic
Actions

Authored by sdepiets on Aug 9 2018, 9:02 AM.

Details

Reviewers
mlaurent
aacid
ltoscano
shaforostoff
yurchor
Group Reviewers
Localization
Commits
R456:1d0867bf9128: Add a README.md with some info for Github and Phabricator

Diff Detail

Repository
R456 Lokalize
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sdepiets requested review of this revision.Aug 9 2018, 9:02 AM
sdepiets created this revision.
mlaurent accepted this revision.Aug 9 2018, 10:18 AM

Seems ok for me

This revision is now accepted and ready to land.Aug 9 2018, 10:18 AM
yurchor requested changes to this revision.Aug 9 2018, 10:23 AM
yurchor added a subscriber: yurchor.
yurchor added inline comments.
README.md
7

Typo: lokalike -> lokalize

This revision now requires changes to proceed.Aug 9 2018, 10:23 AM
ltoscano added a comment.Aug 9 2018, 10:30 AM

One small fix inline:

(another personal comment, which does not require a change, is that I don't think that there is a need to mention GitHub or Phabricator - maybe in the opposite order; a README is useful anyway).

README.md
7

This is the canonical URL:
https://docs.kde.org/?application=lokalize

sdepiets updated this revision to Diff 39372.Aug 10 2018, 1:32 AM

Fix typo + link on title

This revision was not accepted when it landed; it landed in state Needs Review.Aug 10 2018, 1:33 AM
Closed by commit R456:1d0867bf9128: Add a README.md with some info for Github and Phabricator (authored by sdepiets). · Explain Why
This revision was automatically updated to reflect the committed changes.
sdepiets added a comment.EditedAug 10 2018, 1:34 AM
In D14703#305913, @aacid wrote:

What to link https://www.kde.org/applications/development/lokalize/ ?

I've added the link on the bold Lokalize in the intro

Revision Contents
Changeset List

PathPackages
AMREADME.md (17 lines)

Diff 39373

View Options

README.md

Loading...