Currently the file is not "saved as" if it hasn't been modified, which can lead to some confusion.
With this revision the file will be saved as long as the new path is different from the old one.
BUG: 364093
Details
Details
- Reviewers
aacid ltoscano shaforostoff mlaurent - Group Reviewers
Localization - Commits
- R456:fcd47259b449: Save as saves the file to a new path even if there was no changes
Diff Detail
Diff Detail
- Repository
- R456 Lokalize
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 1749 Build 1767: arc lint + arc unit
| src/editortab.cpp | ||
|---|---|---|
| 951 | why this weird QString::compare? why not just "filePath == m_catalog->url()" that is imho easier to understnad? | |
Comment Actions
Looks good to me, if you want, maybe it makes sense to put
filePath.isEmpty() ? m_catalog->url() : filePath
into a variable and then use that variable instead of that "complex" code in three places, but if you don't want that, that's ok for me too :)