Fix project model issues on file changes
ClosedPublic
Actions

Authored by sdepiets on Aug 24 2018, 4:07 AM.

Details

Reviewers

ltoscano
aacid
mlaurent

Group Reviewers

Localization

Commits

R456:b6f3151185b7: Fix project model issues on file changes

Summary

This revision fixes some issues with the Project Model refreshes

Project view jumps to new (random?) file after closing translation file https://bugs.kde.org/show_bug.cgi?id=348757
Whole project is refreshed when a file is changed https://bugs.kde.org/show_bug.cgi?id=343371
Moving or adding a file/folder into the project root will trigger a bug where only that file/folder is displayed

It mostly fixes behaviors which are applied to directories while they shouldn't (like cache requests for directories that return empty values, or unnecessary full regeneration).

BUG: 348757
BUG: 343371

Test Plan

I've tested the following test matrix :

Move/Add/Remove/Save x File or Folder
Within the root folder, within subfolders (same or different), between the root and a subfolder

This is for a .po project architecture, I would be interested to know if the behavior doesn't create regressions with a .po/.pot or other architecture (which might be more buggy to begin with).

Diff Detail

Repository

R456 Lokalize

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

sdepiets requested review of this revision.Aug 24 2018, 4:07 AM

sdepiets created this revision.

Harbormaster completed remote builds in B2188: Diff 40347.Aug 24 2018, 4:07 AM

sdepiets edited the summary of this revision. (Show Details)Aug 24 2018, 4:17 AM

sdepiets edited the test plan for this revision. (Show Details)

sdepiets added reviewers: ltoscano, Localization, aacid, mlaurent.

sdepiets added a project: Localization.

If there are no comments I will move forward with this change tomorrow

aacid added inline comments.Aug 28 2018, 8:47 PM

src/project/projectmodel.cpp
1027	i've no idea about this, but maybe use isFile instead of !isDir? Also make fileItem const
1109	since you're moving it and causing a diff, make it const, makes reading the rest of the code easier not having to worry if it's going to change or not.

sdepiets marked 2 inline comments as done.Aug 29 2018, 2:06 AM

sdepiets added inline comments.

src/project/projectmodel.cpp
1109	understood, I'll try to remember to do that going forward

Replace isNotDir by isFile + add const

Harbormaster completed remote builds in B2318: Diff 40594.Aug 29 2018, 2:08 AM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 29 2018, 2:10 AM

Closed by commit R456:b6f3151185b7: Fix project model issues on file changes (authored by sdepiets). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/project/projectmodel.cpp (42 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40347	e49d799		Aug 24 2018, 4:07 AM	★	★
Diff 2	40594	ef644cb	Replace isNotDir by isFile + add const	Aug 29 2018, 2:08 AM	★	★
Diff 3	40595	ef644cb	R456:b6f3151185b746092ad1b2e2ede5130e02c9dc02	Aug 29 2018, 2:10 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
15c539e26300	69a4854181ee	ef644cb3554e	Simon Depiets	Fix project model issues on file changes (Show More…)	Aug 24 2018, 4:07 AM

Diff 40595

View Options

src/project/projectmodel.cpp