Details

Reviewers

aacid
ltoscano
shaforostoff
mlaurent

Group Reviewers

Localization

Commits

R456:1c1e18471043: Switch to the new connect() API

Summary

Switch to the new connect API with removal of the SIGNAL and SLOT calls

This required the following changes

Replace the optional parameters slots by explicit ones to manage the overload conflicts
Additional disconnects in destructors for LokalizeMainWindow and TranslationUnitTextEdit

Diff Detail

Repository

R456 Lokalize

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

sdepiets requested review of this revision.Aug 15 2018, 8:09 AM

sdepiets created this revision.

Harbormaster completed remote builds in B1865: Diff 39764.Aug 15 2018, 8:09 AM

sdepiets added inline comments.Aug 15 2018, 8:31 AM

src/lokalizemainwindow.cpp
147	Had to add this section to prevent segfault on exit
src/xlifftextedit.cpp
111	Had to add this in the destructor to prevent segfault on exit

sdepiets edited the summary of this revision. (Show Details)Aug 15 2018, 8:34 AM

sdepiets added reviewers: Localization, aacid, ltoscano, shaforostoff, mlaurent.

sdepiets added a project: Localization.

broulik added a subscriber: broulik.Aug 15 2018, 8:39 AM

broulik added inline comments.

src/alttransview.cpp
83	When you can use lambdas, you also don't really need `QSignalMapper` since you can just capture the actual `QAction`. But this could/should be done in a separate patch.

Mapping newly created signal

Harbormaster completed remote builds in B1866: Diff 39765.Aug 15 2018, 8:43 AM

aacid added inline comments.Aug 15 2018, 9:39 AM

src/lokalizemainwindow.cpp
324	You can also move the singleshots to new signal QTimer::singleShot(0, this, &LokalizeMainWindow::blabla);

Amended singleShot calls

Harbormaster completed remote builds in B1869: Diff 39782.Aug 15 2018, 10:01 AM

Amended singleShot calls 2

Harbormaster completed remote builds in B1870: Diff 39783.Aug 15 2018, 10:03 AM

sdepiets marked an inline comment as done.Aug 15 2018, 10:04 AM

Cleanup of spacing

Harbormaster completed remote builds in B1891: Diff 39819.Aug 16 2018, 1:17 AM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 16 2018, 2:58 AM

Closed by commit R456:1c1e18471043: Switch to the new connect() API (authored by sdepiets). · Explain Why

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/actionproxy.cpp (2 lines)
M			src/alttransview.cpp (16 lines)
M			src/binunitsview.cpp (10 lines)
M			src/catalog/catalog.h (9 lines)
M			src/catalog/catalog.cpp (11 lines)
M			src/cataloglistview/cataloglistview.cpp (12 lines)
M			src/cataloglistview/catalogmodel.h (3 lines)
M			src/cataloglistview/catalogmodel.cpp (10 lines)
M			src/common/flowlayout.cpp (8 lines)
M			src/common/headerviewmenu.cpp (6 lines)
M			src/common/languagelistmodel.cpp (4 lines)
M			src/editortab.h (6 lines)
M			src/editortab.cpp (265 lines)
M			src/editortab_findreplace.cpp (37 lines)
M			src/editorview.h (17 lines)
M			src/editorview.cpp (57 lines)
M			src/filesearch/filesearchtab.cpp (58 lines)
M			src/glossary/glossary.cpp (2 lines)
M			src/glossary/glossaryview.h (3 lines)
M			src/glossary/glossaryview.cpp (7 lines)
M			src/glossary/glossarywindow.h (6 lines)
M			src/glossary/glossarywindow.cpp (35 lines)
M			src/lokalizemainwindow.h (1 line)
M			src/lokalizemainwindow.cpp (98 lines)
M			src/lokalizesubwindowbase.h (2 lines)
M			src/mergemode/mergecatalog.cpp (8 lines)
M			src/mergemode/mergeview.cpp (2 lines)
M			src/msgctxtview.cpp (6 lines)
M			src/noteeditor.cpp (8 lines)
M			src/phaseswindow.cpp (20 lines)
M			src/prefs/prefs.cpp (29 lines)
M			src/project/projecttab.h (3 lines)
M			src/project/projecttab.cpp (49 lines)
M			src/project/projectwidget.cpp (8 lines)
M			src/syntaxhighlighter.cpp (2 lines)
M			src/tm/dbfilesmodel.cpp (10 lines)
M			src/tm/qaview.cpp (6 lines)
M			src/tm/tmmanager.cpp (36 lines)
M			src/tm/tmscanapi.cpp (4 lines)
M			src/tm/tmtab.h (3 lines)
M			src/tm/tmtab.cpp (51 lines)
M			src/tm/tmview.h (3 lines)
M			src/tm/tmview.cpp (35 lines)
M			src/tools/widgettextcaptureconfig.cpp (6 lines)
M			src/webquery/webquerycontroller.cpp (8 lines)
M			src/webquery/webqueryview.cpp (13 lines)
M			src/xlifftextedit.h (1 line)
M			src/xlifftextedit.cpp (29 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	39764	6e5814c		Aug 15 2018, 8:09 AM	★	★
Diff 2	39765	6e5814c	Mapping newly created signal	Aug 15 2018, 8:43 AM	★	★
Diff 3	39782	6e5814c	Amended singleShot calls	Aug 15 2018, 10:01 AM	★	★
Diff 4	39783	6e5814c	Amended singleShot calls 2	Aug 15 2018, 10:03 AM	★	★
Diff 5	39819	6e5814c	Cleanup of spacing	Aug 16 2018, 1:17 AM	★	★
Diff 6	39820	1fbe462	R456:1c1e1847104391b28e464cf22ffcfa3c892353b0	Aug 16 2018, 2:58 AM	★	★

Switch to the new connect() APIClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 39820

src/actionproxy.cpp

src/alttransview.cpp

src/binunitsview.cpp

src/catalog/catalog.h

src/catalog/catalog.cpp

src/cataloglistview/cataloglistview.cpp

src/cataloglistview/catalogmodel.h

src/cataloglistview/catalogmodel.cpp

src/common/flowlayout.cpp

src/common/headerviewmenu.cpp

src/common/languagelistmodel.cpp

src/editortab.h

src/editortab.cpp

src/editortab_findreplace.cpp

src/editorview.h

src/editorview.cpp

src/filesearch/filesearchtab.cpp

src/glossary/glossary.cpp

src/glossary/glossaryview.h

src/glossary/glossaryview.cpp

src/glossary/glossarywindow.h

src/glossary/glossarywindow.cpp

src/lokalizemainwindow.h

src/lokalizemainwindow.cpp

src/lokalizesubwindowbase.h

src/mergemode/mergecatalog.cpp

src/mergemode/mergeview.cpp

src/msgctxtview.cpp

src/noteeditor.cpp

src/phaseswindow.cpp

src/prefs/prefs.cpp

src/project/projecttab.h

src/project/projecttab.cpp

src/project/projectwidget.cpp

src/syntaxhighlighter.cpp

src/tm/dbfilesmodel.cpp

src/tm/qaview.cpp

src/tm/tmmanager.cpp

src/tm/tmscanapi.cpp

src/tm/tmtab.h

src/tm/tmtab.cpp

src/tm/tmview.h

src/tm/tmview.cpp

src/tools/widgettextcaptureconfig.cpp

src/webquery/webquerycontroller.cpp

src/webquery/webqueryview.cpp

src/xlifftextedit.h

src/xlifftextedit.cpp

Switch to the new connect() API
ClosedPublic
Actions

Revision Contents
Changeset List