Differential D15444

Simplify the behavior of tab switch navigation
ClosedPublic
Actions

Authored by sdepiets on Sep 12 2018, 2:35 AM.

Details

Reviewers
adrianchavesfernandez
huftis
aacid
ltoscano
Group Reviewers
Localization
Commits
R456:2049c62fbb7d: Simplify the behavior of tab switch navigation
Summary

This feature simplifies the behavior of the tab switch navigation.

The Ctrl+[ and Ctrl+] shortcuts become Ctrl+Tab and Ctrl+Maj+Tab and override the previous default QMdiArea's embedded QTabBar shortcuts behavior (which only drew a box around the tab which would be selected once the key was released). The behavior will be similar to Chrome/Konsole by default (switch directly to the next/previous tab in the order the tabs are displayed). The exception will remain when a tab is closed, in that case the previously opened tab will be displayed.

This behavior can be overridden in the menu option by selecting "According to tab activation order". In that case the current behavior (prev tab selects the previously selected tab, next tab selects the oldest selected tab) will be used.

Finally a shortcut was added to just switch between the last two previously activated windows : Ctrl+[.

BUG: 357667

Diff Detail

Repository
R456 Lokalize
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sdepiets requested review of this revision.Sep 12 2018, 2:35 AM
sdepiets created this revision.
sdepiets updated this revision to Diff 41448.Sep 12 2018, 3:12 AM

Adding menu option to use previous behavior

sdepiets edited the summary of this revision. (Show Details)Sep 12 2018, 3:28 AM
sdepiets added reviewers: Localization, adrianchavesfernandez, huftis, aacid, ltoscano.
sdepiets added a project: Localization.
sdepiets updated this revision to Diff 41449.Sep 12 2018, 3:29 AM

Newly added shortcut for Previous Tab

sdepiets edited the summary of this revision. (Show Details)Sep 12 2018, 3:35 AM
sdepiets updated this revision to Diff 41605.Sep 14 2018, 7:57 AM

Removing empty line, Merge branch 'master' into tab_behavior

This revision was not accepted when it landed; it landed in state Needs Review.Sep 14 2018, 7:57 AM
Closed by commit R456:2049c62fbb7d: Simplify the behavior of tab switch navigation (authored by sdepiets). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41606

View Options

src/cataloglistview/cataloglistview.cpp

Loading...
View Options

src/lokalizemainwindow.h

Loading...
View Options

src/lokalizemainwindow.cpp

Loading...
View Options

src/nokde-stubs/prefs.cpp

Loading...
View Options

src/nokde-stubs/prefs_lokalize.h

Loading...
View Options

src/noteeditor.cpp

Loading...
View Options

src/prefs/lokalize.kcfg

Loading...
View Options

src/prefs/prefs_editor.ui

Loading...