In the meantime, the not directly related changes were applied in https://phabricator.kde.org/D27609.

Well, thanks Davide and Alex!

Two duplicates were removed.

Thanks for reviewing, Davide!

Hello, what do you think about using make -j$(nproc) instead of just make this way all the available
cores are used for compiling.
This is just a little trick I sometimes forget to change when I follow build instructions.

As Alex Lohnau proposed, use make -j$(nproc).

I've been using daily those changes for more than a week and everything looked alright. Other people can do their checks. Thanks, Davide!

I've been using daily those changes for more than a week and everything looked alright. Other people can do their checks. Thanks, Davide!

I've been using daily those changes for more than a week and everything looked alright. Other people can do their checks. Thanks, Davide!

Note: There are related changes in https://phabricator.kde.org/D27446

Thanks, Yuri and Davide!

Closed by commit https://cgit.kde.org/krusader.git/commit/?id=419ac6ec839414bbae52849af536bc8ba1da83e4

Thanks, Yuri and Davide!

Thanks, Yuri, Antonio and Davide!

Closing it manually because it wasn't closed automatically when performing the commit.

Closing it manually because it wasn't closed automatically when performing the commit.

This modification and the related one (https://phabricator.kde.org/D23309) can be applied after the latest changes by Yuri to the website (https://phabricator.kde.org/D26754). Thanks Pino, Yuri and Nikita!

This modification and the related one (https://phabricator.kde.org/D24480) can be applied after the latest changes by Yuri to the website (https://phabricator.kde.org/D26754). Thanks Pino, Yuri and Nikita!

Hi! This change seems to be very necessary nowadays. If there's any problem applying it, I can commit it myself.

The new version of the proposal keeps being acceptable, of course :-)

So we have to consider that CTRL+UP/DOWN cannot be used anymore as before and users may complain about it. However, this did
also not work for the embedded terminal (see bug report) and for the sidebar before this patch.

Previously, syncList->setFocus(); was utilized as it was used in three other places in the same file, although with btnCompareDirs->setFocus(); the intentions becomes clearer. Thanks, Alex! (and Yuri :-)

An address was changed, following what Yuri recently applied (e.g. it can be seen in "Fix links on docs.kde.org").

The source code of Krusader has been modified in order to make Krusader build with older software.
With that, maybe some time can be gained.

The changes suggested by Yuri Chornoivan were made, also the USB entity was defined.

Well, as Martin couldn't answer in https://phabricator.kde.org/T8761, time passes, modifications are made in the source code and therefore we are at danger of losing Alex's work (because e.g. nowadays the proposal no longer can be applied as it is), and the situation does not get better: I've tried what Alex proposed and it worked under Kubuntu 18.04 LTS and Kubuntu 19.10 (after adapting that code to the current Krusader codebase, I attach a file that contains the adaptation).

The mentioned links work. Thanks, Yuri!

Meanwhile the other issues are talked about, I performed some tests under Kubuntu 18.04 LTS and Kubuntu 19.10 and the resulting code worked. Thanks, Alex, Yuri and Pino!

The proposal was tested and local and SMB files were correctly transferred files using Kubuntu 18.04 LTS and Kubuntu 19.10. Other people can do their checks. Thanks, Alex! (and Davide for testing)

The improvements worked under Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks. Thanks, Davide!

The base of the idea is good, although after applying changes... Krusader users are not able to keep using the handy Ctrl+↑ and Ctrl+↓ to move focus even if they redefine the Move Focus Up and Move Focus Down keys :-?

Thanks, the proposal worked under Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks.

Note: In other words, the proposal solves the cases where people e.g. search for a file, press Return (or double-click) on a result, and sometimes that action leads them to that file, and sometimes it doesn't.

The new code works using Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks. Thanks, Davide!

That bug has been hindering Krusader users for too long, thanks Davide! :-)

The first part of the splitted code remains in this code review, and the second part is now in https://phabricator.kde.org/D24480 .

This diff contains combined changes on two separate repositories. Phabricator will have a problem with this kind of change. Please split into two reviews. I'm ok with the content.

Hi, Alex, thanks for improving the source code, I would like to add that the krusader/GUI/krhistorycombobox.cpp code has been reviewed recently and replacing

auto keyEvent = static_cast<QKeyEvent *>(event);

with

auto keyEvent = dynamic_cast<QKeyEvent *>(event);

would not be what it's written in https://doc.qt.io/qt-5/qobject.html:

QKeyEvent *keyEvent = static_cast<QKeyEvent *>(event);

The same could be said about

krusader/Panel/krsearchbar.cpp

and its existing

auto *ke = static_cast<QKeyEvent *>(event);

I agree with you. Thanks Alex and Nikita! (and Moritz :-)

Thanks, Alex!

And thanks Nikita, Alex, and Moritz! (and Yuri :-)

Code looks good and still works!

Alex's recommendations were applied in order to ease the reading of the source code (and the changes could be applied quickly :-) ).

Some tests were also performed by Moritz Bunkus (https://bugs.kde.org/show_bug.cgi?id=411446#c10) and he didn't see any problem.

All right, Davide and Nikita, thanks!

Note: For the tests that I performed under Kubuntu 18.04, executing dpkg -l showed:
kio 5.44.0-0ubuntu1 amd64 Resource and network access abstraction

Some tests were also performed by Moritz Bunkus (https://bugs.kde.org/show_bug.cgi?id=411446#c10) and he didn't see any problem.

Some tests were also performed by Moritz Bunkus (https://bugs.kde.org/show_bug.cgi?id=411446#c10) and he didn't see any problem.

The new code works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide!