In D17129#382302, @varunp wrote:

Most of the features in gsmartcontrol look like they have already been transferred to json. I can try to add all of this in the next few months. Is there any timeline on the next release of partitionmanager/kpmcore?

In D17129#382057, @varunp wrote:

We can try this out, since I have some more time now, I decided to continue with the 'tab' idea discussed during Google Code-In. Not sure about the names of the tabs though. Tell me if you prefer this, I think it leaves a lot of room for expanding this feature if needed.
Image 1
Image 2

In D17129#381530, @varunp wrote:

In D17129#381250, @stikonas wrote:

One issue I found with this is that if text is longer in translated languages, it is not visible (e.g. Firmware revision).

Any particular languages? I think expanding the label's area would do for this.

One issue I found with this is that if text is longer in translated languages, it is not visible (e.g. Firmware revision).

Pushed.

In D17683#379487, @stikonas wrote:

I'll push it later today.

I'll push it later today.

In D17129#365497, @varunp wrote:

In D17129#365496, @stikonas wrote:

Ok, I found it. It looks like you are in the disabled-developers group. Not sure why... Were you inactive in KDE for some time?

I just joined, I am working on Google Code-In. It could also be that I have yet to receive an account verification email.

Ok, I found it. It looks like you are in the disabled-developers group. Not sure why... Were you inactive in KDE for some time?

In D17129#365465, @varunp wrote:

arc land is throwing an error:

fatal: remote error: service not enabled: /partitionmanager.git

Is there any solution, I am new to using arc and Phabricator.

Oh and please add

BUG: 401230

Maybe ship this first. If you want to add bad sectors and power cycles (which I am fine with), then in a separate commit.

Can you attach some before and after screenshots? I think this is usually customary with GUI changes.

Actually now I'm thinking, maybe we should always read KNAME for devices and partitions and store it. We need it in quite a few places in the code and I think right now we just follow symlinks.

It fixes the problem for me. So in principle it can go in. I would probably put on command line parameter per line, easier to read.

Yeah, then it should be defined for VolumeGroupDevice in the GUI and LVM VG, RAID devices should implement their methods...

In D16344#349054, @aacid wrote:

In D16344#348985, @stikonas wrote:

Can you confirm that it works with TLSv1.2 only sites? (e.g. https://stikonas.eu:5281/admin/). Ideally we should test with TLSv1.3 too.

Yes, it works. And https://tls13.crypto.mozilla.org/ works too (on Konqueror using KHTML, sadly not on falkon because i guess it doesn't use the kioslave infrastructure, but that's a different story i guess)

Line 89 in https://api.kde.org/frameworks/kio/html/ktcpsocket_8cpp_source.html suggests that it is the same as QSsl:SecureProtocols.

I don't mess with keyboards enough to be able to say whether this is a good feature or a change that will be annoying.

I tested this patch and it works for me.

Maybe it be better to use SI abbreviations with decimals?
With SI units we always use the same symbol, it's 1 km, 3.5 km, 0.5 km, etc...

In D16090#340265, @acrouthamel wrote:

Can you only use amazon.de? Or can USA people use amazon.com as well?

Maybe make DocTools optional if you already touch it...

By the way, is there any backtrace? Just so that we can compare it to some of those crash on exit bugs on bugzilla... (e.g. https://bugs.kde.org/show_bug.cgi?id=384476)

Well, I guess good to go since it fixes crashes on exit. I wonder if it's the same crash on exit many people were getting but I can't reproduce.

Can you fix a spelling mistake in the comment? (casuses)

Thanks for letting me know!

In R433:7ddc10d3e51c0e0982b654a5fe6a8daa3ba10850#3684686, @wbauer wrote:

In R433:7ddc10d3e51c0e0982b654a5fe6a8daa3ba10850#3684679, @stikonas wrote:

Ah. Sorry, a small misunderstanding. Well, nothing harmful at least :).

Indeed.

So just to arrange, let's push the minimum KF5 version to 5.44?
That would also make it possible to remove some workarounds for other bugs in KF5 I added...

As I said, I plan to do that early next week. So speek up before that if you disagree. ;-)

In R433:7ddc10d3e51c0e0982b654a5fe6a8daa3ba10850#3684676, @wbauer wrote:

In R433:7ddc10d3e51c0e0982b654a5fe6a8daa3ba10850#3684675, @stikonas wrote:

I thought we agreed that we don't need to bump minimum version...

Yes, but I also wrote in the bug report that I'll do it for master/18.12:

But I'd rather wait for 18.12 with that, as you say.

I.e. I'll do it for master, and then raise the minimum KF5 version...

I probably wasn't clear enough though.

So, I do plan to raise the minimum KF5 version for 18.12.
Unless you disagree, but I somehow think you don't... ;-)

In R433:7ddc10d3e51c0e0982b654a5fe6a8daa3ba10850#3684671, @wbauer wrote:

Thanks!

I didn't forget about it though, I'll upgrade the minimum KF5 versions next week.