Diffusion KGet 7ddc10d3e51c

Revert "TrayIcon: Explicitly show/hide the main window if requested"

Authored by stikonas on Aug 14 2018, 4:48 PM.

Description

Revert "TrayIcon: Explicitly show/hide the main window if requested"

This was fixed in KNotification 5.44.

Other KDE Applications already depend on 5.47 in 18.08, so this workaround
will definitely be unnecessary by the time 18.12 is released.

This reverts commit ccefe1842cb34a530fa18cd878b7a7f56654d99c.

wbauer added a subscriber: wbauer.Aug 14 2018, 9:28 PM

Thanks!

I didn't forget about it though, I'll upgrade the minimum KF5 versions next week.

Thanks!

I didn't forget about it though, I'll upgrade the minimum KF5 versions next week.

I thought we agreed that we don't need to bump minimum version...

Well, I just saw some other email today about KDE PIm requiring new KF5 version, so somehow that reminded me of this.

I thought we agreed that we don't need to bump minimum version...

Yes, but I also wrote in the bug report that I'll do it for master/18.12:

But I'd rather wait for 18.12 with that, as you say.

I.e. I'll do it for master, and then raise the minimum KF5 version...

I probably wasn't clear enough though.

So, I do plan to raise the minimum KF5 version for 18.12.
Unless you disagree, but I somehow think you don't... ;-)

I thought we agreed that we don't need to bump minimum version...

Yes, but I also wrote in the bug report that I'll do it for master/18.12:

But I'd rather wait for 18.12 with that, as you say.

I.e. I'll do it for master, and then raise the minimum KF5 version...

I probably wasn't clear enough though.

So, I do plan to raise the minimum KF5 version for 18.12.
Unless you disagree, but I somehow think you don't... ;-)

Ah. Sorry, a small misunderstanding. Well, nothing harmful at least :).

Ah. Sorry, a small misunderstanding. Well, nothing harmful at least :).

Indeed.

So just to arrange, let's push the minimum KF5 version to 5.44?
That would also make it possible to remove some workarounds for other bugs in KF5 I added...

As I said, I plan to do that early next week. So speek up before that if you disagree. ;-)

Ah. Sorry, a small misunderstanding. Well, nothing harmful at least :).

Indeed.

So just to arrange, let's push the minimum KF5 version to 5.44?
That would also make it possible to remove some workarounds for other bugs in KF5 I added...

As I said, I plan to do that early next week. So speek up before that if you disagree. ;-)

Sure. That's fine.