Can you attach some before and after screenshots? I think this is usually customary with GUI changes.

New GUI

Also, I was considering switching Power Cycles and Bad Sectors, wanted to know what you all think.

Oh and please add

BUG: 401230

to your commit message.

arc land is throwing an error:

fatal: remote error: service not enabled: /partitionmanager.git

Is there any solution, I am new to using arc and Phabricator.

In D17129#365465, @varunp wrote:

arc land is throwing an error:

fatal: remote error: service not enabled: /partitionmanager.git

Is there any solution, I am new to using arc and Phabricator.

I am not particularly knowledgeable in arc but it might be that you simply have no commit access yet. I couldn't find your account on KDE Identity.

If so, either I or Caio can commit this for you.

In D17129#365475, @stikonas wrote:

In D17129#365465, @varunp wrote:

arc land is throwing an error:

fatal: remote error: service not enabled: /partitionmanager.git

Is there any solution, I am new to using arc and Phabricator.

I am not particularly knowledgeable in arc but it might be that you simply have no commit access yet. I couldn't find your account on KDE Identity.

If so, either I or Caio can commit this for you.

My account should exist on KDE identity but feel free to commit it.

Ok, I found it. It looks like you are in the disabled-developers group. Not sure why... Were you inactive in KDE for some time?

In D17129#365496, @stikonas wrote:

Ok, I found it. It looks like you are in the disabled-developers group. Not sure why... Were you inactive in KDE for some time?

I just joined, I am working on Google Code-In. It could also be that I have yet to receive an account verification email.

In D17129#365497, @varunp wrote:

In D17129#365496, @stikonas wrote:

Ok, I found it. It looks like you are in the disabled-developers group. Not sure why... Were you inactive in KDE for some time?

I just joined, I am working on Google Code-In. It could also be that I have yet to receive an account verification email.

Oh ok, makes sense. Anyway, I can commit this for you under your name with git commit --author but I'll need your email.

In D17129#365498, @stikonas wrote:

In D17129#365497, @varunp wrote:

In D17129#365496, @stikonas wrote:

Ok, I found it. It looks like you are in the disabled-developers group. Not sure why... Were you inactive in KDE for some time?

I just joined, I am working on Google Code-In. It could also be that I have yet to receive an account verification email.

Oh ok, makes sense. Anyway, I can commit this for you under your name with git commit --author but I'll need your email.

varun-patel@live.com

One issue I found with this is that if text is longer in translated languages, it is not visible (e.g. Firmware revision).

In D17129#381250, @stikonas wrote:

One issue I found with this is that if text is longer in translated languages, it is not visible (e.g. Firmware revision).

Any particular languages? I think expanding the label's area would do for this.

In D17129#381530, @varunp wrote:

In D17129#381250, @stikonas wrote:

One issue I found with this is that if text is longer in translated languages, it is not visible (e.g. Firmware revision).

Any particular languages? I think expanding the label's area would do for this.

I noticed it with Lithuanian (lt_LT.UTF-8). Expanding label area might work. I can try to do it later myself, but I might not have enough time these days, so might have to wait a bit.

In D17129#382057, @varunp wrote:

We can try this out, since I have some more time now, I decided to continue with the 'tab' idea discussed during Google Code-In. Not sure about the names of the tabs though. Tell me if you prefer this, I think it leaves a lot of room for expanding this feature if needed.
Image 1
Image 2

Yes, I quite like it. In fact, eventually we can try to read more data:

https://www.freeware.de/images/screenshot_slideshow/gsmartcontrol-screenshot-54e839931b038.png
(actually I suggest just downloading gsmartcontrol).

Also see https://www.smartmontools.org/ticket/766 They are slowly exposing more data in JSON.

Most of the features in gsmartcontrol look like they have already been transferred to json. I can try to add all of this in the next few months. Is there any timeline on the next release of partitionmanager/kpmcore?

In D17129#382302, @varunp wrote:

Most of the features in gsmartcontrol look like they have already been transferred to json. I can try to add all of this in the next few months. Is there any timeline on the next release of partitionmanager/kpmcore?

No timeline yet. First of all, there needs to be a new release of smartmontools. But probably best to work in a branch for a while.

In D17129#382304, @stikonas wrote:

In D17129#382302, @varunp wrote:

Most of the features in gsmartcontrol look like they have already been transferred to json. I can try to add all of this in the next few months. Is there any timeline on the next release of partitionmanager/kpmcore?

No timeline yet. First of all, there needs to be a new release of smartmontools. But probably best to work in a branch for a while.

I just noticed that smartmontools 7.0 was released two days ago.

There are still some issues with KAuth that needs fixing before a new release can be made but if you want to work on this, I think it's better to target it for Partition Manager 4.1, not 4.0. So I would suggest working on a separate branch.

P.S. KDE infrastructure might also be upgraded to handle pull request (so will be easier than using phabricator).