Fri, Jul 5
Sure, you've got 2 approvals (3 now).
Wed, Jul 3
should I land this?
okay. Landing it. \o/
Snore toast will already get installed but the notifications will be missing.
We still haven't landed KNotifications patch, so I'm waiting on that, since this patch uses SnoreToast call.
We could land it anyway, and instructions related to SnoreToast will just start working after landing the KNotifications patch(es)
Wed, Jun 26
Has this been landed yet? Is there any reason to keep it open?
Wed, Jun 19
removed executable key since it's deprecated ✂
Tue, Jun 18
Jun 18 2019
closing this as duplicate
awesome! landing this! 🎉
ah ok, I thought it was linked without your code change
umm, phonon isn't used for Windows notifications with/without the upcoming notifybysnoretoast back-end. Can we not land this?
Jun 17 2019
Hi, wile adding snoretoast as dep is correct, removing phonon might break existing releases.
Jun 9 2019
I think we should wait until the code was released and then only version dependant.
Jun 8 2019
Jun 7 2019
closing this diff wrt https://cgit.kde.org/craft.git/commit/?id=ca58925512c2d553576259bde8f390e518c12384
removed context-based shortcut handing
Jun 6 2019
SnoreToast supports absolute path now!
Jun 5 2019
the new diff has correct shortcut installations and removals upon un-installation. be sure to update craft by
before testing :)