Thu, Apr 18
Is there something I still need to do here? I was on vacation.
Wed, Apr 17
Tue, Apr 9
Could you split this change?
I'm willing to add the 2019 support but the setup script should not mention it yet.
Tue, Apr 2
Fri, Mar 29
Tue, Mar 26
Also, I tested with VS2017, and everything seemed to work.
The current patch set reflects changes made since that test.
I think this responds to most of the first round comments.
VS2017 is now the default choice, although I have not hidden VS2019 as you suggested.
The other oddity I noticed is that the Qt version is lower in my version than yours.
The diff is against 738d01f314235d89691d20f78b0cdd689f059779 refs/remotes/origin/master
origin https://github.com/KDE/craft.git (fetch)
Mar 25 2019
To manage this review you can use arcanist (craft arcanist).
Mar 24 2019
Thank you for your rapid response.
Mar 21 2019
Mar 10 2019
Jan 6 2019
We can specify the size of the window so I guess your free to come up with something
Do you have an example of those as well?
Jan 5 2019
I guess we could also use one for the mac dmgs
Basically, yes and it looks horrible
Is it just the blue image?
Dec 24 2018
Nov 3 2018
Oct 19 2018
its not optimal to patch this on our side but lets do it for now
Oct 9 2018
Hm but Qt doesn't do mmap? When a rcc is loaded it reads the whole file to ram?
so this is only needed for mingw?
Oct 2 2018
Fix method signature in MultiSource.py
Oct 1 2018
besides my nitpicking it looks good please apply the change and push it :)
Sep 30 2018
Continuous integration support
We need to handle ci mode