CraftProject
ActivePublic

Details

Description

Craft

Craft is an open source meta build system and package manager.
It manages dependencies and builds libraries and applications from source, on Windows, Mac, Linux and FreeBSD.

Repository: https://cgit.kde.org/craft.git/
Wiki: https://community.kde.org/Craft

Recent Activity

Thu, Apr 18

rboylan added a comment to D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..

Is there something I still need to do here? I was on vacation.

Thu, Apr 18, 10:27 PM · Craft

Wed, Apr 17

vonreth abandoned D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..
Wed, Apr 17, 8:36 AM · Craft
vonreth commandeered D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..

merged

Wed, Apr 17, 8:36 AM · Craft

Tue, Apr 9

vonreth added a comment to D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..

Could you split this change?
I'm willing to add the 2019 support but the setup script should not mention it yet.

Tue, Apr 9, 2:33 PM · Craft

Tue, Apr 2

bencreasy added a watcher for Craft: bencreasy.
Tue, Apr 2, 1:35 AM

Fri, Mar 29

vonreth added inline comments to D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..
Fri, Mar 29, 11:09 PM · Craft

Tue, Mar 26

rboylan added a comment to D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..

Also, I tested with VS2017, and everything seemed to work.
The current patch set reflects changes made since that test.

Tue, Mar 26, 7:22 PM · Craft
rboylan updated the diff for D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..

I think this responds to most of the first round comments.
VS2017 is now the default choice, although I have not hidden VS2019 as you suggested.
The other oddity I noticed is that the Qt version is lower in my version than yours.
The diff is against 738d01f314235d89691d20f78b0cdd689f059779 refs/remotes/origin/master
with
origin https://github.com/KDE/craft.git (fetch)

Tue, Mar 26, 7:18 PM · Craft

Mar 25 2019

vonreth added a comment to D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..

To manage this review you can use arcanist (craft arcanist).
https://secure.phabricator.com/book/phabricator/article/arcanist_diff/

Mar 25 2019, 2:03 PM · Craft

Mar 24 2019

rboylan updated the summary of D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..
Mar 24 2019, 10:18 PM · Craft
rboylan added a comment to D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..

Thank you for your rapid response.

Mar 24 2019, 8:33 PM · Craft

Mar 21 2019

vonreth added inline comments to D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..
Mar 21 2019, 8:27 AM · Craft
vonreth requested changes to D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..

Thx!

Mar 21 2019, 8:25 AM · Craft
rboylan requested review of D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..
Mar 21 2019, 3:06 AM · Craft

Mar 10 2019

wojnilowicz abandoned D12726: Add Weboob.
Mar 10 2019, 6:50 AM · Craft

Jan 6 2019

vonreth added a comment to T7849: Image for Craft based Windows Installer.

We can specify the size of the window so I guess your free to come up with something

Jan 6 2019, 10:59 AM · Craft
pinheiro added a comment to T7849: Image for Craft based Windows Installer.

Do you have an example of those as well?

Jan 6 2019, 10:41 AM · Craft

Jan 5 2019

vonreth added a comment to T7849: Image for Craft based Windows Installer.

I guess we could also use one for the mac dmgs

Jan 5 2019, 11:45 AM · Craft
vonreth added a comment to T7849: Image for Craft based Windows Installer.

Basically, yes and it looks horrible

Jan 5 2019, 11:37 AM · Craft
pinheiro claimed T7849: Image for Craft based Windows Installer.

Is it just the blue image?

Jan 5 2019, 11:30 AM · Craft
vonreth reopened T7849: Image for Craft based Windows Installer as "Open".
Jan 5 2019, 9:51 AM · Craft
vonreth closed T3218: Bootstrap, don't allow existing drives for subst. as Resolved.
Jan 5 2019, 9:39 AM · Craft
vonreth lowered the priority of T3218: Bootstrap, don't allow existing drives for subst. from Unbreak Now! to Needs Triage.
Jan 5 2019, 9:39 AM · Craft
vonreth triaged T3218: Bootstrap, don't allow existing drives for subst. as Unbreak Now! priority.
Jan 5 2019, 9:39 AM · Craft

Dec 24 2018

hoetzel added a watcher for Craft: hoetzel.
Dec 24 2018, 7:27 PM

Nov 3 2018

hechenlan added a watcher for Craft: hechenlan.
Nov 3 2018, 7:52 AM

Oct 19 2018

vonreth closed D14938: Force ki18n to build with the libintl.so path.
Oct 19 2018, 7:48 PM · Craft
vonreth accepted D14938: Force ki18n to build with the libintl.so path.

its not optimal to patch this on our side but lets do it for now

Oct 19 2018, 4:39 PM · Craft

Oct 9 2018

sdepiets closed D16062: Add a blueprint for mman-win32 and dependency in kiten.
Oct 9 2018, 9:18 AM · Craft, Windows
kfunk added a comment to D16062: Add a blueprint for mman-win32 and dependency in kiten.

Hm but Qt doesn't do mmap? When a rcc is loaded it reads the whole file to ram?

Oct 9 2018, 9:08 AM · Craft, Windows
vonreth added a comment to D16062: Add a blueprint for mman-win32 and dependency in kiten.

Hm but Qt doesn't do mmap? When a rcc is loaded it reads the whole file to ram?

Oct 9 2018, 8:54 AM · Craft, Windows
kfunk added inline comments to D16062: Add a blueprint for mman-win32 and dependency in kiten.
Oct 9 2018, 8:43 AM · Craft, Windows
vonreth accepted D16062: Add a blueprint for mman-win32 and dependency in kiten.
Oct 9 2018, 8:41 AM · Craft, Windows
sdepiets updated the diff for D16062: Add a blueprint for mman-win32 and dependency in kiten.

Fix description

Oct 9 2018, 8:39 AM · Craft, Windows
vonreth added a comment to D16062: Add a blueprint for mman-win32 and dependency in kiten.

so this is only needed for mingw?

Oct 9 2018, 8:37 AM · Craft, Windows
sdepiets added projects to D16062: Add a blueprint for mman-win32 and dependency in kiten: Windows, Craft.
Oct 9 2018, 8:33 AM · Craft, Windows

Oct 2 2018

sdepiets closed D15850: Offer to redownload the files when they are corrupted.
Oct 2 2018, 3:18 PM · Craft
sdepiets updated the diff for D15850: Offer to redownload the files when they are corrupted.

Fix method signature in MultiSource.py

Oct 2 2018, 3:12 PM · Craft
vonreth accepted D15850: Offer to redownload the files when they are corrupted.
Oct 2 2018, 10:12 AM · Craft
sdepiets updated the diff for D15850: Offer to redownload the files when they are corrupted.

Requested changes

Oct 2 2018, 7:29 AM · Craft

Oct 1 2018

vonreth added inline comments to D15850: Offer to redownload the files when they are corrupted.
Oct 1 2018, 8:11 PM · Craft
vonreth accepted D15850: Offer to redownload the files when they are corrupted.

besides my nitpicking it looks good please apply the change and push it :)

Oct 1 2018, 7:23 PM · Craft

Sep 30 2018

sdepiets updated the diff for D15850: Offer to redownload the files when they are corrupted.

Continuous integration support

Sep 30 2018, 3:40 PM · Craft
sdepiets closed D15849: Fix python install and bump to 3.6.6.
Sep 30 2018, 9:08 AM · Craft
sdepiets added a comment to D15850: Offer to redownload the files when they are corrupted.

We need to handle ci mode

Do you mean disable the prompt when ci mode is enabled ?

I think that would be best, or to automatically use the default response.
On the other hand using the default could result in endless loops (not with your prompts but in general)

Sep 30 2018, 9:00 AM · Craft
vonreth added a comment to D15850: Offer to redownload the files when they are corrupted.

We need to handle ci mode

Do you mean disable the prompt when ci mode is enabled ?

Sep 30 2018, 8:47 AM · Craft
sdepiets added a comment to D15850: Offer to redownload the files when they are corrupted.

We need to handle ci mode

Sep 30 2018, 8:45 AM · Craft
vonreth accepted D15849: Fix python install and bump to 3.6.6.

looks good

Sep 30 2018, 8:43 AM · Craft
vonreth requested changes to D15850: Offer to redownload the files when they are corrupted.

We need to handle ci mode

Sep 30 2018, 8:39 AM · Craft
sdepiets added a project to D15850: Offer to redownload the files when they are corrupted: Craft.
Sep 30 2018, 8:24 AM · Craft