CraftProject
ActivePublic

Details

Description

Craft

Craft is an open source meta build system and package manager.
It manages dependencies and builds libraries and applications from source, on Windows, Mac, Linux and FreeBSD.

Repository: https://cgit.kde.org/craft.git/
Wiki: https://community.kde.org/Craft

Recent Activity

Fri, Jul 5

brute4s99 closed D21658: add snoretoast for win32 builds to knotifs blueprint.
Fri, Jul 5, 3:24 PM · Craft
albertvaka accepted D21658: add snoretoast for win32 builds to knotifs blueprint.

Sure, you've got 2 approvals (3 now).

Fri, Jul 5, 1:01 PM · Craft

Wed, Jul 3

brute4s99 added a comment to D21658: add snoretoast for win32 builds to knotifs blueprint.

should I land this?

Wed, Jul 3, 6:23 PM · Craft
brute4s99 closed D21602: Add NSIS Script for KDE Connect.
Wed, Jul 3, 10:33 AM · Craft, KDE Connect
brute4s99 added a comment to D21602: Add NSIS Script for KDE Connect.

okay. Landing it. \o/

Wed, Jul 3, 10:30 AM · Craft, KDE Connect
vonreth accepted D21602: Add NSIS Script for KDE Connect.

ship it.
Snore toast will already get installed but the notifications will be missing.

Wed, Jul 3, 7:27 AM · Craft, KDE Connect
brute4s99 added a comment to D21602: Add NSIS Script for KDE Connect.

We still haven't landed KNotifications patch, so I'm waiting on that, since this patch uses SnoreToast call.
We could land it anyway, and instructions related to SnoreToast will just start working after landing the KNotifications patch(es)

Wed, Jul 3, 6:55 AM · Craft, KDE Connect

Wed, Jun 26

sredman added a comment to D21602: Add NSIS Script for KDE Connect.

Has this been landed yet? Is there any reason to keep it open?

Wed, Jun 26, 9:50 PM · Craft, KDE Connect
brute4s99 closed D22100: add syntax-highlighting dep for building kio-extras.
Wed, Jun 26, 1:43 PM · Craft
vonreth accepted D22100: add syntax-highlighting dep for building kio-extras.
Wed, Jun 26, 6:27 AM · Craft
brute4s99 updated the summary of D22100: add syntax-highlighting dep for building kio-extras.
Wed, Jun 26, 5:50 AM · Craft
brute4s99 requested review of D22100: add syntax-highlighting dep for building kio-extras.
Wed, Jun 26, 5:50 AM · Craft

Wed, Jun 19

brute4s99 updated the diff for D21602: Add NSIS Script for KDE Connect.

removed executable key since it's deprecated ✂

Wed, Jun 19, 11:29 PM · Craft, KDE Connect

Tue, Jun 18

vonreth added inline comments to D21602: Add NSIS Script for KDE Connect.
Tue, Jun 18, 12:02 PM · Craft, KDE Connect

Jun 18 2019

brute4s99 updated the diff for D21658: add snoretoast for win32 builds to knotifs blueprint.

rebased

Jun 18 2019, 9:22 AM · Craft
brute4s99 added a comment to D21588: Add Snoretoast to Notifications.

https://phabricator.kde.org/D21658

Jun 18 2019, 9:14 AM · Craft
brute4s99 abandoned D21588: Add Snoretoast to Notifications.

closing this as duplicate

Jun 18 2019, 9:14 AM · Craft
vonreth added a comment to D21657: remove phonon from deps if building for win32.

Reverted

Jun 18 2019, 9:09 AM · Craft
brute4s99 updated the diff for D21658: add snoretoast for win32 builds to knotifs blueprint.

rebased

Jun 18 2019, 9:08 AM · Craft
brute4s99 closed D21657: remove phonon from deps if building for win32.
Jun 18 2019, 8:57 AM · Craft
brute4s99 added a comment to D21657: remove phonon from deps if building for win32.

awesome! landing this! 🎉

Jun 18 2019, 8:56 AM · Craft
vonreth accepted D21657: remove phonon from deps if building for win32.

ah ok, I thought it was linked without your code change

Jun 18 2019, 8:55 AM · Craft
brute4s99 added a comment to D21657: remove phonon from deps if building for win32.

umm, phonon isn't used for Windows notifications with/without the upcoming notifybysnoretoast back-end. Can we not land this?

Jun 18 2019, 8:46 AM · Craft

Jun 17 2019

vonreth added a comment to D21588: Add Snoretoast to Notifications.

Hi, wile adding snoretoast as dep is correct, removing phonon might break existing releases.

Jun 17 2019, 7:48 AM · Craft

Jun 9 2019

vonreth accepted D21658: add snoretoast for win32 builds to knotifs blueprint.
Jun 9 2019, 4:59 PM · Craft
vonreth requested changes to D21657: remove phonon from deps if building for win32.

I think we should wait until the code was released and then only version dependant.

Jun 9 2019, 4:42 PM · Craft
albertvaka accepted D21657: remove phonon from deps if building for win32.

LGTM

Jun 9 2019, 4:17 PM · Craft
albertvaka accepted D21658: add snoretoast for win32 builds to knotifs blueprint.

LGTM

Jun 9 2019, 4:16 PM · Craft

Jun 8 2019

brute4s99 retitled D21658: add snoretoast for win32 builds to knotifs blueprint from add snoretoast for win32 builds to add snoretoast for win32 builds to knotifs blueprint .
Jun 8 2019, 10:15 PM · Craft
sredman accepted D21602: Add NSIS Script for KDE Connect.
Jun 8 2019, 2:59 AM · Craft, KDE Connect

Jun 7 2019

brute4s99 added a dependent revision for D21657: remove phonon from deps if building for win32: D21660: remove dbus for windows build and change audio dep logic.
Jun 7 2019, 11:47 PM · Craft
brute4s99 added dependent revisions for D21602: Add NSIS Script for KDE Connect: D21588: Add Snoretoast to Notifications, D21658: add snoretoast for win32 builds to knotifs blueprint, D21661: add snoretoast backend for KNotifications on Windows.
Jun 7 2019, 11:46 PM · Craft, KDE Connect
brute4s99 added a dependency for D21588: Add Snoretoast to Notifications: D21602: Add NSIS Script for KDE Connect.
Jun 7 2019, 11:46 PM · Craft
brute4s99 added a dependency for D21658: add snoretoast for win32 builds to knotifs blueprint: D21602: Add NSIS Script for KDE Connect.
Jun 7 2019, 11:46 PM · Craft
brute4s99 added a project to D21658: add snoretoast for win32 builds to knotifs blueprint: Craft.
Jun 7 2019, 11:23 PM · Craft
brute4s99 added a project to D21657: remove phonon from deps if building for win32: Craft.
Jun 7 2019, 11:21 PM · Craft
brute4s99 abandoned D21615: Context - aware shortcuts for NSIS based installers.

closing this diff wrt https://cgit.kde.org/craft.git/commit/?id=ca58925512c2d553576259bde8f390e518c12384

Jun 7 2019, 11:13 PM · Craft
vonreth accepted D21602: Add NSIS Script for KDE Connect.
Jun 7 2019, 6:33 PM · Craft, KDE Connect
brute4s99 updated the diff for D21602: Add NSIS Script for KDE Connect.

removed context-based shortcut handing

Jun 7 2019, 5:54 PM · Craft, KDE Connect

Jun 6 2019

brute4s99 updated the diff for D21602: Add NSIS Script for KDE Connect.

SnoreToast supports absolute path now!

Jun 6 2019, 5:13 PM · Craft, KDE Connect
vonreth added inline comments to D21615: Context - aware shortcuts for NSIS based installers.
Jun 6 2019, 12:58 PM · Craft
vonreth added inline comments to D21602: Add NSIS Script for KDE Connect.
Jun 6 2019, 10:24 AM · Craft, KDE Connect
vonreth added inline comments to D21602: Add NSIS Script for KDE Connect.
Jun 6 2019, 10:21 AM · Craft, KDE Connect

Jun 5 2019

brute4s99 updated the diff for D21602: Add NSIS Script for KDE Connect.
Jun 5 2019, 10:56 PM · Craft, KDE Connect
brute4s99 added a comment to D21602: Add NSIS Script for KDE Connect.

the new diff has correct shortcut installations and removals upon un-installation. be sure to update craft by

craft craft

before testing :)

Jun 5 2019, 10:15 PM · Craft, KDE Connect
brute4s99 updated the diff for D21602: Add NSIS Script for KDE Connect.
Jun 5 2019, 10:14 PM · Craft, KDE Connect
brute4s99 updated the test plan for D21602: Add NSIS Script for KDE Connect.
Jun 5 2019, 10:05 PM · Craft, KDE Connect
brute4s99 requested review of D21615: Context - aware shortcuts for NSIS based installers.
Jun 5 2019, 10:04 PM · Craft
brute4s99 closed D21612: Add Un.Sections to NSIS Template.
Jun 5 2019, 10:02 PM · Craft
vonreth accepted D21612: Add Un.Sections to NSIS Template.

looks good, if the section is does end up in the right place this looks perfect :)

Jun 5 2019, 8:40 PM · Craft