sengels (Patrick Spendrin)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 9:26 AM (451 w, 3 d)
Availability
Available

Recent Activity

Apr 21 2020

sengels committed R877:76ed7cd93681: Merge branch 'master' of https://invent.kde.org/kde/craft-blueprints-kde (authored by sengels).
Merge branch 'master' of https://invent.kde.org/kde/craft-blueprints-kde
Apr 21 2020, 12:15 PM
sengels committed R877:6b68787712b2: akonadi-contacts: Use another patch (authored by sengels).
akonadi-contacts: Use another patch
Apr 21 2020, 12:15 PM

Jan 30 2019

sengels committed R877:2282fd5b88bb: fix builderror for real (authored by sengels).
fix builderror for real
Jan 30 2019, 8:57 AM

Jan 24 2019

sengels committed R877:dfa0c163e5c2: fix building of akonadi-contacts (authored by sengels).
fix building of akonadi-contacts
Jan 24 2019, 2:09 PM

Aug 8 2017

sengels committed R32:3b34e1ca2987: replace noexcept by Q_DECL_NOEXCEPT (authored by sengels).
replace noexcept by Q_DECL_NOEXCEPT
Aug 8 2017, 4:56 PM
sengels committed R32:293a11143c47: do not export simple template class (authored by sengels).
do not export simple template class
Aug 8 2017, 4:49 PM
sengels committed R32:129f9dc1f2d5: use same indent also on windows (authored by sengels).
use same indent also on windows
Aug 8 2017, 4:15 PM
sengels committed R32:61110beea29d: fix generation of template archives (authored by sengels).
fix generation of template archives
Aug 8 2017, 4:15 PM
sengels committed R32:cd49c39a705b: CursorInRevision cannot be called (authored by sengels).
CursorInRevision cannot be called
Aug 8 2017, 4:14 PM
sengels committed R32:2df22b8b6506: use Declaration* again, somehow QList<> cannot be casted on msvc as with gcc (authored by sengels).
use Declaration* again, somehow QList<> cannot be casted on msvc as with gcc
Aug 8 2017, 4:14 PM
sengels committed R32:d111eb7f1936: fix build on msvc (authored by sengels).
fix build on msvc
Aug 8 2017, 4:14 PM
sengels committed R32:ca96d0481bf0: give over the directory in question directly to zip, simply using the work… (authored by sengels).
give over the directory in question directly to zip, simply using the work…
Aug 8 2017, 3:50 PM
sengels committed R32:3d3cb61efc9f: fix linkage under windows (authored by sengels).
fix linkage under windows
Aug 8 2017, 3:50 PM
sengels committed R32:714fbac0ebbe: don't export inlined functions (doesn't work on mingw4) (authored by sengels).
don't export inlined functions (doesn't work on mingw4)
Aug 8 2017, 3:47 PM
sengels committed R32:658f0e951ae3: build fix (authored by sengels).
build fix
Aug 8 2017, 3:42 PM
sengels committed R32:b93ad74c2691: the crash has been fixed by fixing initialization order (authored by sengels).
the crash has been fixed by fixing initialization order
Aug 8 2017, 3:38 PM
sengels committed R32:26009ccf3295: one beer for every forgotten file.close() ;-) (can't be deleted otherwise) (authored by sengels).
one beer for every forgotten file.close() ;-) (can't be deleted otherwise)
Aug 8 2017, 3:37 PM
sengels committed R32:db3d977c1cb3: add the possibility to run the command from the shell (authored by sengels).
add the possibility to run the command from the shell
Aug 8 2017, 3:37 PM
sengels committed R32:0c05185e3a54: remove endless loop after a crash (authored by sengels).
remove endless loop after a crash
Aug 8 2017, 3:37 PM
sengels committed R32:618141716866: add a fixme and a short explanation (authored by sengels).
add a fixme and a short explanation
Aug 8 2017, 3:37 PM
sengels committed R32:300708c44cee: for now disable this as it makes kdevelop die on windows (authored by sengels).
for now disable this as it makes kdevelop die on windows
Aug 8 2017, 3:37 PM
sengels committed R32:133f945fbd76: cleanup a bit; use constantly m_controller after it has been set. (authored by sengels).
cleanup a bit; use constantly m_controller after it has been set.
Aug 8 2017, 3:37 PM
sengels committed R32:2dfae009dc25: fix Qt 4.4 issue for amilcar ;-) (authored by sengels).
fix Qt 4.4 issue for amilcar ;-)
Aug 8 2017, 3:32 PM
sengels committed R32:59a8079af92b: fix 'first seen as class' error (authored by sengels).
fix 'first seen as class' error
Aug 8 2017, 3:26 PM
sengels committed R32:8ed35f776f74: it is one subdirectory more (authored by sengels).
it is one subdirectory more
Aug 8 2017, 3:26 PM

Sep 10 2016

sengels committed R172:4744e7870952: windows doesn't understand ' on commandline (authored by sengels).
windows doesn't understand ' on commandline
Sep 10 2016, 6:36 AM
sengels committed R173:4744e7870952: windows doesn't understand ' on commandline (authored by sengels).
windows doesn't understand ' on commandline
Sep 10 2016, 6:26 AM
sengels committed R172:5c87956bd54c: msvc compile++ - please return something (authored by sengels).
msvc compile++ - please return something
Sep 10 2016, 6:07 AM
sengels committed R172:47100930e234: fix linker error on win32 - please tell me if this is the wrong place. (authored by sengels).
fix linker error on win32 - please tell me if this is the wrong place.
Sep 10 2016, 6:06 AM
sengels committed R172:6f1af2bc21da: this has to be a temporary solution; the last install breaks on windows builds (authored by sengels).
this has to be a temporary solution; the last install breaks on windows builds
Sep 10 2016, 6:04 AM
sengels committed R172:d89186222900: this is an uglyhack but I don't see another solution - or is splitting install… (authored by sengels).
this is an uglyhack but I don't see another solution - or is splitting install…
Sep 10 2016, 6:04 AM
sengels committed R173:5c87956bd54c: msvc compile++ - please return something (authored by sengels).
msvc compile++ - please return something
Sep 10 2016, 5:58 AM
sengels committed R173:47100930e234: fix linker error on win32 - please tell me if this is the wrong place. (authored by sengels).
fix linker error on win32 - please tell me if this is the wrong place.
Sep 10 2016, 5:56 AM
sengels committed R173:6f1af2bc21da: this has to be a temporary solution; the last install breaks on windows builds (authored by sengels).
this has to be a temporary solution; the last install breaks on windows builds
Sep 10 2016, 5:55 AM
sengels committed R173:d89186222900: this is an uglyhack but I don't see another solution - or is splitting install… (authored by sengels).
this is an uglyhack but I don't see another solution - or is splitting install…
Sep 10 2016, 5:55 AM
sengels committed R138:b4b8d40dbc0f: first kind of stable release (authored by sengels).
first kind of stable release
Sep 10 2016, 4:45 AM
sengels committed R138:ce7ad02c0672: fix frameworks (authored by sengels).
fix frameworks
Sep 10 2016, 4:43 AM
sengels committed R138:7b9076fe67a3: Merge branch 'python3' into frameworks (authored by sengels).
Merge branch 'python3' into frameworks
Sep 10 2016, 4:43 AM
sengels committed R138:62d652cea673: Merge branch 'python3' into frameworks (authored by sengels).
Merge branch 'python3' into frameworks
Sep 10 2016, 4:43 AM
sengels committed R138:d93cdec6c1e3: Merge branch 'python3' into frameworks (authored by sengels).
Merge branch 'python3' into frameworks
Sep 10 2016, 4:43 AM
sengels committed R138:738d38aa196c: Merge branch 'python3' into frameworks (authored by sengels).
Merge branch 'python3' into frameworks
Sep 10 2016, 4:43 AM
sengels committed R138:17581c601ff8: Merge branch 'python3' into frameworks (authored by sengels).
Merge branch 'python3' into frameworks
Sep 10 2016, 4:43 AM
sengels committed R138:9ec941c5ef1d: Merge branch 'python3' into frameworks (authored by sengels).
Merge branch 'python3' into frameworks
Sep 10 2016, 4:43 AM
sengels committed R138:162fd30e761b: Merge branch 'python3' into frameworks (authored by sengels).
Merge branch 'python3' into frameworks
Sep 10 2016, 4:43 AM
sengels committed R138:642373c307b9: Merge branch 'python3' into frameworks (authored by sengels).
Merge branch 'python3' into frameworks
Sep 10 2016, 4:43 AM
sengels committed R138:748f206b95a2: update to cmake 2.8.7 again - still bzip2 error is to be expected (authored by sengels).
update to cmake 2.8.7 again - still bzip2 error is to be expected
Sep 10 2016, 4:43 AM
sengels committed R138:67f40aa4a3d2: add dependency to extra-cmake-modules (authored by sengels).
add dependency to extra-cmake-modules
Sep 10 2016, 4:43 AM
sengels committed R138:a3d47d376714: use temporary windows branch for now (authored by sengels).
use temporary windows branch for now
Sep 10 2016, 4:43 AM
sengels committed R138:52f9e3a88ac5: add extra-cmake-modules, required to build kdelibs (authored by sengels).
add extra-cmake-modules, required to build kdelibs
Sep 10 2016, 4:43 AM
sengels committed R138:942826a7b5d9: Merge branch 'python3' into frameworks (authored by sengels).
Merge branch 'python3' into frameworks
Sep 10 2016, 4:43 AM
sengels committed R138:a0cb1c8d6b8c: also fix digest (authored by sengels).
also fix digest
Sep 10 2016, 4:43 AM
sengels committed R138:385cec8b6434: move on to cmake 2.8.6 (authored by sengels).
move on to cmake 2.8.6
Sep 10 2016, 4:43 AM
sengels committed R138:ddce88736c17: remove base, kde_build and msys_build since these are deprecated and to old… (authored by sengels).
remove base, kde_build and msys_build since these are deprecated and to old…
Sep 10 2016, 4:42 AM
sengels committed R138:773947617229: remove all imports of base module - I double checked that (authored by sengels).
remove all imports of base module - I double checked that
Sep 10 2016, 4:42 AM
sengels committed R138:6b606bfb24a1: Merge branch 'python3' of git://anongit.kde.org/emerge into frameworks (authored by sengels).
Merge branch 'python3' of git://anongit.kde.org/emerge into frameworks
Sep 10 2016, 4:42 AM
sengels committed R138:ee3edec5e1dd: use frameworks branch of kdelibs (authored by sengels).
use frameworks branch of kdelibs
Sep 10 2016, 4:42 AM
sengels committed R138:3ec3532b2368: merge branch master (authored by sengels).
merge branch master
Sep 10 2016, 4:42 AM
sengels committed R138:ae831481032c: remove version support for InstallDB also remove support for file based… (authored by sengels).
remove version support for InstallDB also remove support for file based…
Sep 10 2016, 4:42 AM
sengels committed R138:ed414eeb5d33: add version information to the database (authored by sengels).
add version information to the database
Sep 10 2016, 4:42 AM
sengels committed R138:76dd848a8bf1: remove unneeded debug output (authored by sengels).
remove unneeded debug output
Sep 10 2016, 4:42 AM
sengels committed R138:6c0f38e2890d: make revision support working (authored by sengels).
make revision support working
Sep 10 2016, 4:42 AM
sengels committed R138:b9277a196f9d: add the revision flag and some idea how to fill it (authored by sengels).
add the revision flag and some idea how to fill it
Sep 10 2016, 4:42 AM
sengels committed R138:fae2a4722aa5: Merge branch 'master' into emerge-versions2 (authored by sengels).
Merge branch 'master' into emerge-versions2
Sep 10 2016, 4:42 AM
sengels committed R138:091e11bb01c3: Merge branch 'master' into emerge-versions2 (authored by sengels).
Merge branch 'master' into emerge-versions2
Sep 10 2016, 4:42 AM
sengels committed R138:a9cd23913826: Merge branch 'master' into emerge-versions2 (authored by sengels).
Merge branch 'master' into emerge-versions2
Sep 10 2016, 4:42 AM
sengels committed R138:949e67449638: remove some more occurances of versions (authored by sengels).
remove some more occurances of versions
Sep 10 2016, 4:42 AM
sengels committed R138:3df73ecad9af: rebase old patch and reapply (authored by sengels).
rebase old patch and reapply
Sep 10 2016, 4:42 AM
sengels committed R34:57b33b0b726f: correct the fix (authored by sengels).
correct the fix
Sep 10 2016, 4:10 AM
sengels committed R34:6ffa5368989c: update fix for M_PI not defined in math.h on msvc (authored by sengels).
update fix for M_PI not defined in math.h on msvc
Sep 10 2016, 4:10 AM
sengels committed R106:9085bdfa0ef9: do not use the systemsettingsview as a shared library under mingw - the static… (authored by sengels).
do not use the systemsettingsview as a shared library under mingw - the static…
Sep 10 2016, 3:44 AM
sengels committed R106:6a54017e970d: fix application icon for systemsettings on windows backport of r991049 (authored by sengels).
fix application icon for systemsettings on windows backport of r991049
Sep 10 2016, 3:44 AM
sengels committed R106:aaff09511907: fix systemsettings application icon (authored by sengels).
fix systemsettings application icon
Sep 10 2016, 3:42 AM
sengels committed R106:07dfa5980197: fix for mingw (authored by sengels).
fix for mingw
Sep 10 2016, 3:23 AM

Jan 22 2016

sengels committed R138:5f46fdfe47b1: add msvc2013 compiler (authored by sengels).
add msvc2013 compiler
Jan 22 2016, 9:58 AM
sengels committed R138:e6a64e0b1d58: do not raise exception for no good reason e.g. make it work as before. (authored by sengels).
do not raise exception for no good reason e.g. make it work as before.
Jan 22 2016, 9:58 AM

Jan 4 2016

sengels accepted D728: Added support for sha2 checksums..

Hm, it would be cool if you could split this into several requests next time...

Jan 4 2016, 2:50 PM

Jan 1 2016

sengels accepted D727: Git: Optimize repo update, dont poll twice.
Jan 1 2016, 11:33 PM
sengels requested changes to D725: Emerge: Add --compile-fast option.

hey, hey, stop, stop. There might be a better solution:
CMake itself has a target nmake install/fast which doesn't retest whether files have been modified and simply runs the install step.
I am against the change in this way, for the following reasons:

  1. Your option doesn't "compile fast" but simply skips the make step (and redoes it in the install step)
  2. If you would have that option enabled, running emerge --compile will result in emerge --configure only (which I would call broken)
  3. If you run emerge --qmerge you would get make, install, and qmerge at the same time.
Jan 1 2016, 10:59 PM
sengels added a comment to D724: Fix emerge output.

Looks good, have you checked all comparisons against verbose() function?

Jan 1 2016, 10:41 PM
sengels added a comment to D728: Added support for sha2 checksums..

General: Please try to find a single style for spaces and parentheses: either no spaces, or spaces after/before parentheses. Please don't mix, especially not in a single line...

  1. Is it possible to have unittests when e.g. EmergeDebug.py and EmergeHash.py are run directly? Since you add EmergeHash here, could you write some lines that test e.g. that algorithms are found correctly, that empty files (or some specially generated temporary files) do have a reproduceable hash?
Jan 1 2016, 10:35 PM

Aug 25 2015

sengels committed R33:3b34e1ca2987: replace noexcept by Q_DECL_NOEXCEPT (authored by sengels).
replace noexcept by Q_DECL_NOEXCEPT
Aug 25 2015, 9:41 AM

Aug 24 2015

sengels updated subscribers of T598: Windows: Make sure CMake location is configurable.
Aug 24 2015, 9:27 AM · KDevelop