mhubner (Marc Hübner)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2017, 7:18 PM (97 w, 6 d)
Availability
Available

Recent Activity

Oct 26 2018

mhubner added a project to D16433: Display name of equity with strikeout font if the equity account has been closed.: KMyMoney.
Oct 26 2018, 2:12 AM · KMyMoney
mhubner requested review of D16433: Display name of equity with strikeout font if the equity account has been closed..
Oct 26 2018, 2:07 AM · KMyMoney

Oct 16 2018

mhubner added a project to D16239: Allow for arbitrary documents to be stored with splits.: KMyMoney.
Oct 16 2018, 3:01 AM · KMyMoney
mhubner requested review of D16239: Allow for arbitrary documents to be stored with splits..
Oct 16 2018, 2:49 AM · KMyMoney

May 20 2018

mhubner added a comment to D12979: Format mymoney headers according to the KDE guidelines.

So how did those changes travelled to the repository? Through conventional post in an envelope on a diskette? :)

Are you seriously questioning that people in distributed teams worked on software before the internet? I certainly remember passing sourcecode around on floppy disks and CDs myself. This was a pain in the neck and I'm sort of jealous of you if you didn't have to go through that. Just because you didn't does not mean noone did, though.

May 20 2018, 6:10 PM · KMyMoney
mhubner added a comment to D12979: Format mymoney headers according to the KDE guidelines.

[...] That's the "metric" (as you called it) you can apply only to names who had an account in CVS. They've contributed directly through CVS, so they can be identified by CVS logs. [...]

May 20 2018, 2:43 PM · KMyMoney

May 19 2018

mhubner added a comment to D12979: Format mymoney headers according to the KDE guidelines.

Another problematic example is kmymoney/mymoney/mymoneyinstitution.cpp where you removed Michael Edwardes. The first comment for this file in CVS is by Thomas and says "[...] renamed MyMoneyBank to MyMoneyInstitution, also all references[...]".
When you look into the 0.3.1 release on the sourceforge page that Jack linked, you'll find that the original mymoneybank.cpp does only list Michael in the header - he seems to be a legit contributor to this file if not the initial author.
This also kind of disproves your "Let's be real, if someone had an account in cvs for commiting code, then he wouldn't ask someone else for commiting it for them. You can see proofs of any work on cvs stats, mailing list and logs, that I linked above." argument in D12836.

May 19 2018, 11:50 PM · KMyMoney
mhubner added a comment to D12979: Format mymoney headers according to the KDE guidelines.

The topic seems a little bit hot and I think because of some misconceptions going on here:

  1. people added their names to the headers either by themselves or asking someone else to add it for them,
  2. people contributed to the files,
May 19 2018, 11:09 PM · KMyMoney
mhubner added a comment to D12979: Format mymoney headers according to the KDE guidelines.

Wow. Don't you think that "kicking somebody off the project" seems a little harsh? In the end, those people claimed their authorship through adding their names to the headers (and that's what -when push comes to shove- really matters), not through comments on a mailing list or cvs commits. To me, removing someone who did potentially contribute (and, honestly speaking, why would someone add him/herself to the headers of the source files if they didn't?) in any form (technically this could have been verbally expressed advice, review or anything that happened offline before checking the code in) is (in lack of better words) morally questionable and, at the very least, just rude. How would you feel if in a year or two someone removes your name arguing that he or she doesn't see you as a valid author/contributor because of some kind of self defined metric (cvs commits, in this case)? In your opinion - what is the improvement (to the code, the application, the project, or anything) or gain resulting from removing those people?

May 19 2018, 5:39 PM · KMyMoney

Apr 20 2018

mhubner updated the diff for D10614: Custom icons for accounts.

Custom icons for accounts
don't store icons in database as discussed in review.

Apr 20 2018, 11:54 PM · KMyMoney

Mar 17 2018

mhubner updated the diff for D11406: add color coding of pos/neg amounts for 'posted value' column.

add color coding of pos/neg amounts for 'posted value' column

Mar 17 2018, 3:30 PM · KMyMoney
mhubner added a project to D11406: add color coding of pos/neg amounts for 'posted value' column: KMyMoney.
Mar 17 2018, 3:41 AM · KMyMoney
mhubner updated the diff for D11406: add color coding of pos/neg amounts for 'posted value' column.

add color coding of pos/neg amounts for 'posted value' column

Mar 17 2018, 3:40 AM · KMyMoney
mhubner requested review of D11406: add color coding of pos/neg amounts for 'posted value' column.
Mar 17 2018, 3:38 AM · KMyMoney

Mar 11 2018

mhubner added a comment to D10001: display reconciliation date on homepage.

Would anyone with write access to the repo mind taking care of the merge, please?
Thanks!

Mar 11 2018, 9:11 PM · KMyMoney
mhubner added a project to D11249: Fix missing semicolon that breaks craft/windows build.: KMyMoney.
Mar 11 2018, 9:09 PM · KMyMoney
mhubner updated the diff for D11249: Fix missing semicolon that breaks craft/windows build..

Fix missing semicolon that breaks craft/windows build.

Mar 11 2018, 9:08 PM · KMyMoney
mhubner requested review of D11249: Fix missing semicolon that breaks craft/windows build..
Mar 11 2018, 9:05 PM · KMyMoney

Feb 18 2018

mhubner added inline comments to D10614: Custom icons for accounts.
Feb 18 2018, 4:36 PM · KMyMoney

Feb 17 2018

mhubner updated the summary of D10614: Custom icons for accounts.
Feb 17 2018, 8:01 PM · KMyMoney
mhubner retitled D10614: Custom icons for accounts from This patch adds the possibility to assign a custom icon to each account. to Custom icons for accounts.
Feb 17 2018, 7:57 PM · KMyMoney
mhubner requested review of D10614: Custom icons for accounts.
Feb 17 2018, 7:55 PM · KMyMoney

Feb 7 2018

mhubner added inline comments to R261:44f846f13d0f: Make compilation work on MSVC 2017.
Feb 7 2018, 1:02 AM

Jan 22 2018

mhubner updated the diff for D10001: display reconciliation date on homepage.

incorporated feedback from Thomas and Jack.

Jan 22 2018, 12:06 AM · KMyMoney

Jan 20 2018

mhubner retitled D10001: display reconciliation date on homepage from this patch adds the possibility to have the corrresponding reconciliation date displayed alongside each account on the home page. This is optional and can be enabled or disabled via a setting in the config dialog. to display reconciliation date on homepage.
Jan 20 2018, 10:54 PM · KMyMoney

Nov 2 2017

mhubner added a comment to D8426: remove unused unistd.h includes.

Since I don't have write access to the repository - would either of you mind taking care of the merge?

Nov 2 2017, 12:00 AM · KMyMoney

Nov 1 2017

mhubner updated the diff for D8426: remove unused unistd.h includes.
  • fixed blanks betw. parenthesis and brace
  • renamed getters
  • removed const keyword for return type
  • added error message to cmake file
Nov 1 2017, 4:06 AM · KMyMoney

Oct 28 2017

mhubner added inline comments to D8426: remove unused unistd.h includes.
Oct 28 2017, 11:27 PM · KMyMoney
mhubner updated the diff for D8426: remove unused unistd.h includes.

incorporated review feedback

Oct 28 2017, 11:21 PM · KMyMoney

Oct 27 2017

mhubner updated the diff for D8426: remove unused unistd.h includes.

I updated the patch as described above - moved the platform specific stuff into an own library and linked that conditionally. That takes care of all unistd.h / pwd.h related build issues in MSVC that I am aware of.
As I said, if you guys feel that #ifdef's in the source itself are the better solution, I'll be happy to change that accordingly - just let me know.

Oct 27 2017, 2:25 AM · KMyMoney
mhubner added a comment to D8411: add qtwebkit dependency to kmymoney blueprint.

That makes sense, thanks for clarifying.
Would you mind taking care of merging the patch (I don't have write access to the repo)?
Thanks!

Oct 27 2017, 2:20 AM · Craft

Oct 25 2017

mhubner created D8458: snore notification fails due to undefined CraftCore.
Oct 25 2017, 3:44 AM · Craft

Oct 24 2017

mhubner updated the diff for D8411: add qtwebkit dependency to kmymoney blueprint.

Changed to runtime dependency as requested.

Oct 24 2017, 1:00 AM · Craft
mhubner added a comment to D8426: remove unused unistd.h includes.

How come it compiles on MSVC if unistd.h is included unconditionally in e.g. kselectdatabasedlg.cpp for geteuid?

Oct 24 2017, 12:42 AM · KMyMoney

Oct 22 2017

mhubner created D8426: remove unused unistd.h includes.
Oct 22 2017, 8:32 PM · KMyMoney
mhubner created D8411: add qtwebkit dependency to kmymoney blueprint.
Oct 22 2017, 2:40 AM · Craft

Sep 30 2017

mhubner added a member for KMyMoney: mhubner.
Sep 30 2017, 12:45 AM
mhubner added a comment to D8052: Add ECM dependency to libalkimia blueprint.

Hi Hannah,

Sep 30 2017, 12:39 AM · Craft
mhubner updated the diff for D8052: Add ECM dependency to libalkimia blueprint.
Sep 30 2017, 12:36 AM · Craft

Sep 29 2017

mhubner created D8052: Add ECM dependency to libalkimia blueprint.
Sep 29 2017, 3:31 AM · Craft

Sep 21 2017

mhubner created D7903: Make KDiagram depend on QtSvg.
Sep 21 2017, 2:42 AM · Craft

May 28 2017

mhubner added a member for Craft: mhubner.
May 28 2017, 11:54 AM

Mar 5 2017

mhubner added a watcher for KMyMoney: mhubner.
Mar 5 2017, 7:19 PM