This adds support for generators and generator delegation
according to:
Details
- Reviewers
zhigalin - Commits
- R52:d0363ecdc430: Add support for Generators.
Diff Detail
- Repository
- R52 KDevelop: PHP Support
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Hello.
Sorry for the late reply, I haven't noticed when this review was created
This adds support for generators and generator delegation
This is great, with this patch the [T6816: PHP 5.5 features] will be fully supported!
The path looks good to me.
If you want to attract attention simply write ping in the comments.
Fell free to do it more frequently, it have been here for more than 1 month and I totally missed it.
parser/phplexer.cpp | ||
---|---|---|
810–811 | This smells like spaghetti, are you sure? how about something like auto nextToken = QString(); nextToken += * lookAhead; nextToken += * ++lookAhead; nextToken += * ++lookAhead; nextToken += * ++lookAhead; if (pos + 1 < m_contentSize && nextToken == QStringLiteral("from")) { (example code, not sure it will work) |
I rebased this against master and found it has the same problem as D13547, i.e. it introduces 10 first/follow conflicts :/
Not sure it's worth trying to solve it here either.
If you want to attract attention simply write ping in the comments.
Fell free to do it more frequently, it have been here for more than 1 month and I totally missed it.
I merely saw that mine are the only reviews that miss it, so I added it. I'll use pings in the future :)
I think we have more pressing issues like namespaces handling which makes KDevelop hard to use with any of PHP frameworks.
I would opt to complete PHP 5.5 support at least...
parser/phplexer.cpp | ||
---|---|---|
810–811 | Minor adjustments, but it seems to work. Thanks! :) |