Deprecate AbstractBarcode::minimumSize() also for the compiler
Needs ReviewPublic

Authored by kossebau on Thu, May 14, 1:27 PM.

Details

Reviewers
svuorela
vkrause
Group Reviewers
Frameworks

Diff Detail

Repository
R280 Prison
Branch
fullydeprecateminimumsize
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26898
Build 26916: arc lint + arc unit
kossebau created this revision.Thu, May 14, 1:27 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptThu, May 14, 1:27 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Thu, May 14, 1:27 PM
kossebau added inline comments.Thu, May 14, 1:30 PM
src/lib/abstractbarcode.h
69

D29573 bringing _BELATED only landed a few days ago, but can already serve here for another case :)

I think we should wait a bit with formally deprecating. I like add the new, wait a bit, then deprecate.

Also, while I might be a unconventional developer, but given this is a tier 1 library, I'm often hand patching the required ECM version to a much lower version to test stuff when I know it will work. So I'd say. Yes. nice patch, but let's wait a month or two with submitting it.

I think we should wait a bit with formally deprecating. I like add the new, wait a bit, then deprecate.

So you propose to also remove the @deprecated from the API dox?

And wait, for what to happen?

I think we should wait a bit with formally deprecating. I like add the new, wait a bit, then deprecate.

@deprecated since 5.69 Prefer preferredSize() or trueMinimumSize(). is no formal deprecation? It would be for me though, thus I am puzzled why the reader of the API dox & the compiler are differently instructed here currently. Could you elaborate? :)

PIM has been fully adapted meanwhile, only https://phabricator.kde.org/D29478 missing I think.