Differential D26340

touch: Remove deprecated ApplicationHeader
ClosedPublic
Actions

Authored by z3ntu on Jan 1 2020, 12:50 PM.

Details

Reviewers
svuorela
Commits
R1029:0faf250cb5cf: touch: Remove deprecated ApplicationHeader
Summary

Resolves the following warning:

qml: Warning: ApplicationHeader is deprecated, remove and use the automatic internal toolbar instead.
Test Plan

Tested on both desktop and Plasma Mobile.
Looks a bit different on mobile because the "automatic internal toolbar" is smaller than the ApplicationHeader but it even looks better that way.

Diff Detail

Repository
R1029 Cookbook Creator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
z3ntu requested review of this revision.Jan 1 2020, 12:50 PM
z3ntu created this revision.
z3ntu edited the summary of this revision. (Show Details)Jan 1 2020, 12:52 PM
z3ntu edited the test plan for this revision. (Show Details)
z3ntu added a reviewer: svuorela.
svuorela accepted this revision.Jan 1 2020, 2:12 PM
This revision is now accepted and ready to land.Jan 1 2020, 2:12 PM
svuorela added a comment.Mar 4 2020, 6:42 PM

@z3ntu - do you have push access to push this?

z3ntu added a comment.Mar 5 2020, 10:44 AM

@svuorela No I don't have push access

Closed by commit R1029:0faf250cb5cf: touch: Remove deprecated ApplicationHeader (authored by z3ntu). · Explain WhyApr 17 2020, 2:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/touch/qml/main.qml (1 line)

Diff 80396

View Options

src/touch/qml/main.qml

Loading...