Selection scrolling look super cool.

In D20312#446923, @svuorela wrote:

In D20312#445122, @ahmedbilal wrote:

@svuorela If system have user with same Real Name it would return the username of first user. I think, this function should be in Okular instead because there seems to be no use case where it would be used besides showing avatar for PDF's authors. Whats your comment on it.

I think it is less important to get it perfect if it just goes into okular as part of the application. There it can be adapted and evolved slowly. But we should have it perfect if it should land in one of the frameworks. The API defined here is kind of cast in stone.

/Sune

@sander I have added you as reviewer and subscriber.

In D20351#446620, @sander wrote:

Consider splitting the color change into a separate patch. That part seems to be uncontroversial.

The problem with the '3' is that its perceived thickness depends on your screen size and resolution. What looks good to you may look bad on somebody else's computer.

In D20351#446498, @sander wrote:

I like the color part of this patch.

As for the line width: As mentioned, '3' is arbitrary. You need to find a width that takes current dpi into account. Ideally, the width should be what later gets written into the pdf file.

The fact that the rectangle is currently not completely drawn sounds like a Qt bug. What is the pen width without your patch? Even if it has width 0 it should paint a 1-pixel line. Or is the page downscaled somewhere after rendering?

In D20351#445682, @ngraham wrote:

In D20351#445664, @aacid wrote:

3 is an arbitrary width, so -1 for this change

I'm not a huge fan either, but not because it's arbitrary (everything visual is arbitrary) but rather because this makes it look too thick to my eye.

In D20312#444802, @svuorela wrote:

I think unit tests would be nice. Including unit tests documenting the behavior for multiple users with the same full name.

My systems have several users named "Sune Vuorela"

In D20312#444692, @aacid wrote:

This code seems like it could live in Okular instead of kcoreaddons?

@aacid
I also want to add that code in Okular but doesn't it look strange to put User info functionality in Document Reader's code. My first priority is also to add this in Okular. If people here are OK with it then I will close this and add this along with the code that uses it in Okular.

This helper function will be needed in places where we only have access to author/user's Full name. For Example, PDFs have Full Name in authors.