ahmedbilal (Ahmed Bilal)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 5 2019, 5:34 PM (6 w, 2 d)
Availability
Available

Recent Activity

Apr 11 2019

ahmedbilal added a reviewer for D20405: Make preview(dashed rectangle) of rectangle annotation colorful: sander.
Apr 11 2019, 5:46 PM · Okular
ahmedbilal removed a reviewer for D20405: Make preview(dashed rectangle) of rectangle annotation colorful: sander.
Apr 11 2019, 5:46 PM · Okular

Apr 10 2019

ahmedbilal added a comment to D20437: Make selection scrolling go at 60 fps.

Selection scrolling look super cool.

Apr 10 2019, 6:15 PM · Okular
ahmedbilal added inline comments to D20438: Small code simplifications.
Apr 10 2019, 6:12 PM · Konsole
ahmedbilal abandoned D20351: Improve Legibility of preview of rectangle annotation.
Apr 10 2019, 6:02 PM · Okular
ahmedbilal abandoned D20312: get username from full name usernameFromFullname(QString fullname) -> QString.
Apr 10 2019, 6:02 PM · Frameworks

Apr 9 2019

ahmedbilal added a comment to D20312: get username from full name usernameFromFullname(QString fullname) -> QString.

@svuorela If system have user with same Real Name it would return the username of first user. I think, this function should be in Okular instead because there seems to be no use case where it would be used besides showing avatar for PDF's authors. Whats your comment on it.

I think it is less important to get it perfect if it just goes into okular as part of the application. There it can be adapted and evolved slowly. But we should have it perfect if it should land in one of the frameworks. The API defined here is kind of cast in stone.

/Sune

Apr 9 2019, 6:14 PM · Frameworks
ahmedbilal retitled D20351: Improve Legibility of preview of rectangle annotation from Improve Legibility of preview of rectangle annotation and make it same color as resulting rectangle to Improve Legibility of preview of rectangle annotation.
Apr 9 2019, 1:23 PM · Okular
ahmedbilal added a comment to D20405: Make preview(dashed rectangle) of rectangle annotation colorful.

@sander I have added you as reviewer and subscriber.

Apr 9 2019, 1:06 PM · Okular
ahmedbilal added a reviewer for D20405: Make preview(dashed rectangle) of rectangle annotation colorful: sander.
Apr 9 2019, 1:05 PM · Okular
ahmedbilal updated the summary of D20405: Make preview(dashed rectangle) of rectangle annotation colorful.
Apr 9 2019, 1:05 PM · Okular
ahmedbilal updated subscribers of D20405: Make preview(dashed rectangle) of rectangle annotation colorful.
Apr 9 2019, 1:02 PM · Okular
ahmedbilal requested review of D20405: Make preview(dashed rectangle) of rectangle annotation colorful.
Apr 9 2019, 1:01 PM · Okular
ahmedbilal added a comment to D20351: Improve Legibility of preview of rectangle annotation.

Consider splitting the color change into a separate patch. That part seems to be uncontroversial.

The problem with the '3' is that its perceived thickness depends on your screen size and resolution. What looks good to you may look bad on somebody else's computer.

Apr 9 2019, 12:55 PM · Okular
ahmedbilal added a comment to D20351: Improve Legibility of preview of rectangle annotation.

I like the color part of this patch.

As for the line width: As mentioned, '3' is arbitrary. You need to find a width that takes current dpi into account. Ideally, the width should be what later gets written into the pdf file.

The fact that the rectangle is currently not completely drawn sounds like a Qt bug. What is the pen width without your patch? Even if it has width 0 it should paint a 1-pixel line. Or is the page downscaled somewhere after rendering?

Apr 9 2019, 9:17 AM · Okular

Apr 8 2019

ahmedbilal added a comment to D20351: Improve Legibility of preview of rectangle annotation.

3 is an arbitrary width, so -1 for this change

I'm not a huge fan either, but not because it's arbitrary (everything visual is arbitrary) but rather because this makes it look too thick to my eye.

Apr 8 2019, 6:59 AM · Okular

Apr 7 2019

ahmedbilal updated the summary of D20351: Improve Legibility of preview of rectangle annotation.
Apr 7 2019, 7:02 PM · Okular
ahmedbilal added a comment to D20351: Improve Legibility of preview of rectangle annotation.
Apr 7 2019, 7:00 PM · Okular
ahmedbilal added a reviewer for D20351: Improve Legibility of preview of rectangle annotation: ngraham.
Apr 7 2019, 6:54 PM · Okular
ahmedbilal updated the summary of D20351: Improve Legibility of preview of rectangle annotation.
Apr 7 2019, 2:49 PM · Okular
ahmedbilal added reviewers for D20351: Improve Legibility of preview of rectangle annotation: Okular, okular-devel.
Apr 7 2019, 1:33 PM · Okular
ahmedbilal requested review of D20351: Improve Legibility of preview of rectangle annotation.
Apr 7 2019, 1:32 PM · Okular
ahmedbilal added a comment to D20312: get username from full name usernameFromFullname(QString fullname) -> QString.

I think unit tests would be nice. Including unit tests documenting the behavior for multiple users with the same full name.

My systems have several users named "Sune Vuorela"

Apr 7 2019, 9:25 AM · Frameworks
ahmedbilal added a comment to D20312: get username from full name usernameFromFullname(QString fullname) -> QString.

This code seems like it could live in Okular instead of kcoreaddons?

@aacid
I also want to add that code in Okular but doesn't it look strange to put User info functionality in Document Reader's code. My first priority is also to add this in Okular. If people here are OK with it then I will close this and add this along with the code that uses it in Okular.

Apr 7 2019, 7:46 AM · Frameworks

Apr 6 2019

ahmedbilal added reviewers for D20312: get username from full name usernameFromFullname(QString fullname) -> QString: Frameworks, kde-frameworks-devel.
Apr 6 2019, 5:56 PM · Frameworks
ahmedbilal removed a reviewer for D20312: get username from full name usernameFromFullname(QString fullname) -> QString: Okular.
Apr 6 2019, 5:46 PM · Frameworks
ahmedbilal removed a reviewer for D20312: get username from full name usernameFromFullname(QString fullname) -> QString: okular-devel.
Apr 6 2019, 5:40 PM · Frameworks
ahmedbilal added reviewers for D20312: get username from full name usernameFromFullname(QString fullname) -> QString: Okular, okular-devel.
Apr 6 2019, 5:38 PM · Frameworks
ahmedbilal added a comment to D20312: get username from full name usernameFromFullname(QString fullname) -> QString.

This helper function will be needed in places where we only have access to author/user's Full name. For Example, PDFs have Full Name in authors.

Apr 6 2019, 5:37 PM · Frameworks
ahmedbilal requested review of D20312: get username from full name usernameFromFullname(QString fullname) -> QString.
Apr 6 2019, 5:33 PM · Frameworks